References #15005: 24 hour format

ansible / awx

AWX provides a web-based user interface, REST API, and task engine built on top of Ansible. It is one of the upstream projects for Red Hat Ansible Automation Platform.

Other

13.54k stars 3.35k forks source link

References #15005: 24 hour format #15186

Closed aeter closed 2 weeks ago

aeter commented 2 weeks ago

SUMMARY

Related: #15005, #11531

Adds 24 hour format across the UI. Removed the AM and PM. Related to it, changed the date format.

ISSUE TYPE

New or Enhanced Feature

COMPONENT NAME

AWX VERSION

$ make VERSION
awx:

(sorry, this is what I get from the command)

ADDITIONAL INFORMATION

I've ran npm run test (passed) and played around with the user interface after writing the code.

TheRealHaoLiu commented 2 weeks ago

@aeter thanks for the contribution and welcome to the AWX project

awesome PR btw,

question: is this configurable or is the PR just changing it to 24 hour completely?

if we are to accept this we would want both 24 hour and the AM/PM format to be options that user can select

aeter commented 2 weeks ago

It only replaces them to 24h. I'll try to make it configurable. I need to close this PR - the branch name feature/24-hour-format has docker tag errors, seems I cannot use it locally with docker compose-build. I'll open a new PR, and link the PRs, if/when I have improved code. Thanks!