Notification template junk activity stream entry on creation

AlanCoding commented 6 years ago

ISSUE TYPE

Bug Report

COMPONENT NAME

API

SUMMARY

creating NT makes 2 entries where a user would probably prefer 1

ENVIRONMENT

AWX version: X.Y.Z
AWX install method: openshift, minishift, docker on linux, docker for mac, boot2docker
Ansible version: X.Y.Z
Operating System:
Web Browser:

STEPS TO REPRODUCE

Create notification template with some private data

view activity stream

EXPECTED RESULTS

just a creation entry

ACTUAL RESULTS

some examples, including a copy action

As you click on one of the 2nd entries in UI:

{
 "notification_configuration": [
  "{\"username\": \"fooooooo\", \"sender\": \"asdf@invalid.com\", \"recipients\": [\"foo@invaid.com\"], \"use_tls\": false, \"host\": \"foo.invalid\", \"use_ssl\": false, \"password\": \"\", \"port\": 8888}",
  "{\"username\": \"fooooooo\", \"sender\": \"asdf@invalid.com\", \"recipients\": [\"foo@invaid.com\"], \"use_tls\": false, \"host\": \"foo.invalid\", \"use_ssl\": false, \"password\": \"$encrypted$\", \"port\": 8888}"
 ]
}

Better to not create this entry

ADDITIONAL INFORMATION

ryanpetrello commented 4 years ago

After talking with @rebeccahhh, it sounds like this is really just exposing an implementation detail of how we save credential secrets in a two-step process (first we save the credential to generate a primary key, then we update it to encrypt the secret value using the primary key from the insert).

I'm not certain this is really worth addressing, because it would probably be fairly complicated. @AlanCoding it sounds like you and @rebeccahhh discussed this?

That said, I understand that this is a little weird from a UX perspective. @wenottingham do you think it's worth moving mountains to adjust this?

wenottingham commented 4 years ago

If it's matching the operations we currently make in the API, no, it's fine.

ryanpetrello commented 4 years ago

If @AlanCoding agrees with this, then, I'd say it would be better for @rebeccahhh to spend her time on other activity stream hit list items first.

ansible / awx