search

ansible / awx

AWX provides a web-based user interface, REST API, and task engine built on top of Ansible. It is one of the upstream projects for Red Hat Ansible Automation Platform.
Other
13.81k stars 3.39k forks source link

Help text of instance_filters is wrong #2910

Open AlanCoding opened 5 years ago

AlanCoding commented 5 years ago
ISSUE TYPE
COMPONENT NAME
SUMMARY

Instance filters help text claims that it only applies to EC2 sources. The code disagrees.

ENVIRONMENT
STEPS TO REPRODUCE

OPTIONS for inventory source or inventory update, field instance_filters

ACTUAL RESULTS

help text gives

Comma-separated list of filter expressions (EC2 only). Hosts are imported when ANY of the filters match.

EXPECTED RESULTS

Allowed for VMWare & tower types

https://github.com/ansible/awx/blob/271bd10b475312d586951d5ccd4a3a61b0d26824/awx/main/models/inventory.py#L1370-L1371

used for both

https://github.com/ansible/awx/blob/271bd10b475312d586951d5ccd4a3a61b0d26824/awx/main/tasks.py#L1898-L1899

https://github.com/ansible/awx/blob/271bd10b475312d586951d5ccd4a3a61b0d26824/awx/main/tasks.py#L2069

ADDITIONAL INFORMATION
AlanCoding commented 5 years ago

same for group_by

AlanCoding commented 5 years ago

additionally, source_regions has no help text, although its function may be obvious.