search

ansible / awx

AWX provides a web-based user interface, REST API, and task engine built on top of Ansible. It is one of the upstream projects for Red Hat Ansible Automation Platform.
Other
13.82k stars 3.39k forks source link

[ui_next] Schedules, values for 'FrequencyDetailSubform__RunEveryLabel' and 'Detail__DetailName: Repeat Frequency', needs to be marked for translations #6858

Open sshedmake opened 4 years ago

sshedmake commented 4 years ago
ISSUE TYPE
SUMMARY

With Japanese (dummy translation) google-chrome, values for 'FrequencyDetailSubformRunEveryLabel' and 'DetailDetailName: Repeat Frequency', at 'Templates > JT > Schedules > {Edit and Schedule} Details' screen, appears in English (instead of Japanese)

ENVIRONMENT
STEPS TO REPRODUCE
  1. Do a successful login to the ui_next interface in the preferred language (say Japanese)
  2. Navigate to breadcrumb 'Templates > Demo Job Template > Schedules > Run Demo JT 5 Times > {Edit and Schedule} Details'
  3. Observe respective values for 'FrequencyDetailSubformRunEveryLabel' and 'DetailDetailName: Repeat Frequency'
EXPECTED RESULTS

Content should appear in Japanese

ACTUAL RESULTS

  1. 'weeks' | 'months'

  2. 'Every week on Monday, Wednesday, Friday for 5 times' | 'Every month on Monday, Tuesday, Wednesday, Thursday, Friday, Saturday, Sunday until October 27, 2020'

ADDITIONAL INFORMATION
  1. Screenshot higlighting respective values for 'FrequencyDetailSubformRunEveryLabel' and 'DetailDetailName: Repeat Frequency', appearing in English, with Japanese google-chrome:

Run every 1 months: output_months

Run every 1 weeks: output_weeks

nixocio commented 3 years ago

The string for Repeat Frequency is dynamically generated and comes from RRule . After talking with @mabashian about it, we came up with a few possible solutions.

1 - Always show as an English. 2 - Custom translation issue - See: https://github.com/jakubroztocil/rrule/issues/13 3 - Hide the field Repeat Frequency if the browser language is not English. 4 - Remove the field - Repeat Frequency, since the info is already present with UI Occurrences.

@trahman73 @wenottingham @sshedmake thoughts?

mabashian commented 3 years ago

Some more information about this field: https://github.com/ansible/awx/issues/6173

mabashian commented 3 years ago

Enhancement here would be to have this string translated (maybe we roll our own implementation of it?) but we plan on leaving that field for now.

sshedmake commented 1 year ago

Added @Spredzy here