[Meta issue] Credentials bugs

ansible / awx

AWX provides a web-based user interface, REST API, and task engine built on top of Ansible. It is one of the upstream projects for Red Hat Ansible Automation Platform.

Other

13.97k stars 3.41k forks source link

[Meta issue] Credentials bugs #9635

Closed tiagodread closed 3 years ago

tiagodread commented 3 years ago

ISSUE TYPE

Bug Report

SUMMARY

While verifying https://github.com/ansible/awx/pull/9368 I've found a couple of things happening on devel:

[x] 1. Using external secret management system display the component Ace editor wrong

Steps to reproduce:

Create a credential CyberArk Conjur Secret Lookup
Create a credential for AWS using the CyberArk on Secret Key as an external secret management system

[x] 2. Trying to edit the credential replacing the external secret for a pain text and saving:

Steps to reproduce: See the gif.

[x] 3. ~All types with Verify SSL option is being displayed as enabled on the form and details~

chrome-capture (3)

Types:

Tower
CyberArk AIM Central Credential Provider Lookup
OpenShift or Kubernetes API Bearer Token
OpenStack

mabashian commented 3 years ago

3 is a duplicate of #9955 and will be fixed by https://github.com/ansible/awx/pull/9960

tiagodread commented 3 years ago

3 is a duplicate of #9955 and will be fixed by #9960

Fixed by #9960

akus062381 commented 3 years ago

4/29/2021- for Bullet point 1 above, it appears that this problem has not yet been addressed.

tiagodread commented 3 years ago

@mabashian while verifing this issue I found this:

Create a credential CyberArk Conjur Secret Lookup
Create a credential CyberArk AIM Central Credential Provider Lookup
Create an AWS credential using the CyberArk Conjur Secret Lookup on Secret Key as an external secret management system
Edit this AWS credential and select CyberArk AIM Central Credential Provider Lookup as an external secret management system
save the AWS credential

Result:

akus062381 commented 3 years ago

@mabashian Update on this issue: Issues 1 and 2 are fixed and good to go. Issue 3 is still happening except for the Ansible Tower credential type.

mabashian commented 3 years ago

@akus062381 I think you may be referring to the fact that Verify SSL is checked by default on the add form for a handful of credential types. This is by design. The API indicates to us that the default value for those fields is true so we check the checkbox in the add form. Editing the credential seems to correctly check/uncheck that box:

openstack

If I'm misunderstanding send over some reproduction steps and I'll take another look.

akus062381 commented 3 years ago

this is all set.