ansible / community

This repository is being archived. See https://github.com/ansible-community/presentations and https://github.com/ansible-community/meetings for the new locations
Apache License 2.0
489 stars 144 forks source link

Network Working Group Meeting Agenda 2 #247

Closed gundalow closed 6 years ago

gundalow commented 7 years ago

Please leave a comment regarding any agenda item you wish to discuss. If you don't show up for the meeting, your item will be skipped.

If your IRC nick is different from your Github username, leave that as well.

See https://github.com/ansible/community/tree/master/group-network for the schedule

All Core Networking issues (most recently updated at the top): https://github.com/ansible/ansible/issues?q=is%3Aopen+label%3Anetworking+-label%3Aneeds_revision+sort%3Aupdated-desc

Network Working Group: https://github.com/ansible/community/tree/master/group-network

#ansible-network on Freenode IRC

ganeshrn commented 6 years ago

Proposal on Netconf modules: https://github.com/ansible/proposals/issues/104

ganeshrn commented 6 years ago

Deprecation of the use of connection=load in network modules that support connection=network_cli or network=netconf

Qalthos commented 6 years ago

Review HTTP connection proposal ansible/proposals#103

calfonso commented 6 years ago

Minutes: https://meetbot.fedoraproject.org/ansible-network/2018-04-18/network_working_group.2018-04-18-16.00.html

Log: https://meetbot.fedoraproject.org/ansible-network/2018-04-18/network_working_group.2018-04-18-16.00.log.html

brampling commented 6 years ago

I have a customer looking for these which are waiting for review:

https://github.com/ansible/ansible/pull/37543 https://github.com/ansible/ansible/pull/37580 https://github.com/ansible/ansible/pull/37582 https://github.com/ansible/ansible/pull/37583 https://github.com/ansible/ansible/pull/37676 https://github.com/ansible/ansible/pull/37678

brampling commented 6 years ago

With respect to https://github.com/ansible/ansible/issues/39386#issuecomment-384773801

It's not very clear that the NIOS lookup plugins exist. Is there some way to indicate that in the documentation section for the NIOS net_tools modules?

amuraleedhar commented 6 years ago

Please review and merge ansible/ansible#39665 This is a bug fix on cnos util module. This has to be backported to 2.5 as well.

Thank You.

-Anil

acozine commented 6 years ago

Clarifying terminology for network-engine role. Background: We've used the word “parser” to describe the file with the matching rules, the module that does the matching, and the combination of the two. We're working to clarify the usage and make the modules in network-engine easier to understand and use. See https://github.com/ansible-network/network-engine/issues/65.

amuraleedhar commented 6 years ago

Please review and merge ansible/ansible#39955 Here I am modifiying cnos_facts, cnos_command to align with how it is done for other vendors. In addition to this I am adding cnos_config also. Here I am using persistent connection. Therefore all the three plugins are also introduced for this purpose viz. action, cliconf and terminal plugins. The documentation snippet in util is brought into each module documentation as they differ here. module_util/cnos.py is added with all methods that are required for this. Added unit test for each of them. In addition to that i have removed few errors from the ignore.txt as they have been addressed here

Please review and merge

Thank You.

-Anil

amuraleedhar commented 6 years ago

~~ansible/ansible#40218 Starting with our recent CNOS release version 10.7, we have moved certain CLI keywords to match with Industry Standard CLI (ISCLI) keywords. For backward compatibility, old CLI keywords will continue to work for next one or two CNOS releases with a condition that “command acronyms” of old CLI keywords, cannot be used. For eg: Use “display version” instead of “disp ver”. This PR is to expand the acronymns if they are present in the python code~~

This has to be backported to 2.5 as well.

Merged into devel and cherry-picked for release in 2.5.3

mikewiebe commented 6 years ago

I would like to discuss the comments from this PR

I would also like to discuss the following issues:

amuraleedhar commented 6 years ago

~~Please merge the PR ansible/ansible#40865~~

This is to fix the copy paste error in CNOS plugin files. Corrected typo ENOS to CNOS. There was few merge issue in some enos license text. This also fixed.

Merged on May 30

mikewiebe commented 6 years ago

I would like to discuss the following issues:

~~https://github.com/ansible/ansible/issues/40683 https://github.com/ansible/ansible/issues/40902~~

caphrim007 commented 6 years ago

https://github.com/ansible/ansible/issues/40913

No feedback has been solicited yet by core members, so I want to bring this up

Covered in Ansible Core meeting https://meetbot.fedoraproject.org/ansible-meeting/2018-06-05/ansible_irc_core_meeting.2018-06-05-19.04.log.html

amuraleedhar commented 6 years ago

~~Please merge the PR ansible/ansible#41121~~

This is to fix the copy paste error in CNOS facts . This issue came revealed when I ran a coverity scan.

Merged on Jun 5

Qalthos commented 6 years ago

Meeting started Wed Jun 13 16:01:01 2018 UTC. Minutes: https://meetbot.fedoraproject.org/ansible-network/2018-06-13/network_working_group.2018-06-13-16.01.html Minutes (text): https://meetbot.fedoraproject.org/ansible-network/2018-06-13/network_working_group.2018-06-13-16.01.txt Log: https://meetbot.fedoraproject.org/ansible-network/2018-06-13/network_working_group.2018-06-13-16.01.log.html

caphrim007 commented 6 years ago

Same license terms would be included as seen in Ansible's ismount code found here https://github.com/ansible/ansible/blob/6787fc70a643fb6e2bdd2c6a6202072d21db72ef/lib/ansible/module_utils/ismount.py#L7

F5 wants to do this for the following reason

The reason for this is the current implementation in the modules places a dependency that must be met in Ansible (in the form of tests) and met by F5's customers (remembering to install netaddr). This second issue leads to more support requests, which are unnecessary, because this dependency can be removed.

The requested code to include, is provided natively in Python 3.x. This code would be used as a shim until such time as,

I think that based off of the pre-existing work in Ansible, and the known GPL-compatibility of the PSF and GPL3, that this should be a non-issue provided that the ipaddress.py code is clearly documented as such (and that that license does not extend beyond the ipaddress.py file.

There is existing work in Ansible's module utils to support rudimentary IP address work. F5 needs the enhanced library to support IP networks in addition to the existing IP addresses.

This module utility would only be included in F5's module_utils directory; not the larger network/common or its sub dirs. Other module authors using this module_util would assume the risk of it being removed per the bullets mentioned above.

Agreed but punted to tomorrow's core meeting due to licensing issue @Qalthos This was approved by core on 2018-06-21 @caphrim007

Qalthos commented 6 years ago

Meeting started Wed Jun 20 15:59:50 2018 UTC. Minutes: https://meetbot.fedoraproject.org/ansible-network/2018-06-20/network_working_group.2018-06-20-15.59.html Minutes (text): https://meetbot.fedoraproject.org/ansible-network/2018-06-20/network_working_group.2018-06-20-15.59.txt Log: https://meetbot.fedoraproject.org/ansible-network/2018-06-20/network_working_group.2018-06-20-15.59.log.html

amuraleedhar commented 6 years ago

Please merge ansible/ansible#41998

This is to add the expansion of CNOS CLI acronymns into Change Logs

gundalow commented 6 years ago

Ansible 2.6.0 final is now available See From a network point view Connection Plugins

Modules

General

gundalow commented 6 years ago

2018-07-04

Summary of key points

Team status update

09:17 Minutes: https://meetbot.fedoraproject.org/ansible-network/2018-07-04/ansible_network_working_group.2018-07-04-16.00.html 09:17 Minutes (text): https://meetbot.fedoraproject.org/ansible-network/2018-07-04/ansible_network_working_group.2018-07-04-16.00.txt 09:17 Log: https://meetbot.fedoraproject.org/ansible-network/2018-07-04/ansible_network_working_group.2018-07-04-16.00.log.html

fxfitz commented 6 years ago

For the July 11th meeting, I would like to quickly discuss an open PR: https://github.com/ansible/ansible/pull/41985

amuraleedhar commented 6 years ago

Please merge PR ansible/ansible#42500

In this PR, I am moving the legacy code for ssh connectivity from Paramiko to persistent connection of Ansible for cnos_vlan module. Along with this I am trying to take care of the new CLIs introuduced for CNOS. And I have added UT codes for this module. Once this module passes through review process and get merged, I will replicate the paradigm for rest of 14 modules.

gundalow commented 6 years ago

2018-07-04

Summary of key points

Team status update

Actions

Minutes: https://meetbot.fedoraproject.org/ansible-network/2018-07-11/ansible_network_working_group.2018-07-11-16.00.html Minutes (text): https://meetbot.fedoraproject.org/ansible-network/2018-07-11/ansible_network_working_group.2018-07-11-16.00.txt Log: https://meetbot.fedoraproject.org/ansible-network/2018-07-11/ansible_network_working_group.2018-07-11-16.00.log.html

samerd commented 6 years ago

Please merge PR: ansible/ansible#42164 Merged

ganeshrn commented 6 years ago

~Review and test PR https://github.com/ansible/ansible/pull/42847 for community supported platforms~ Merged

amuraleedhar commented 6 years ago

Please merge PR ansible/ansible#43194 In this PR, I am moving the legacy code for ssh connectivity from Paramiko to persistent connection of Ansible for cnos_portchannel, cnos_vlag and cnos_interface module. Along with this I am trying to take care of the new CLIs introuduced for CNOS. And I have added UT codes for this module. This done exactly in line with PR#42500. This code has been tested on a CNOS Mars switch.

Qalthos commented 6 years ago

2018-07-25

Team status update

Actions

amuraleedhar commented 6 years ago

Please merge PR ansible/ansible#43534 In this PR, I am moving the legacy code for ssh connectivity from Paramiko to persistent connection of Ansible for cnos_bgp, cnos_factory, cnos_reload, cnos_save, and cnos_showrun module. Along with this I am trying to take care of the new CLIs introuduced for CNOS. And I have added UT codes for this module. This done exactly in line with PR#42500. This code has been tested on a CNOS Bacon switch. Edited cnos_bgp to move code from cnos.py in Util folder to module code itself. This was done based on one review comment that cnos.py is too large and Qalthos suggested to move its code from util file to module file. Tested it too

gundalow commented 6 years ago

Contributors Summit, AnsibleFest Austin 2018 What would you like to see discussed at the Community Summit, this is your opportunity to to ask questions either related to Networking, or the Community in general, feel free to add any topics to: https://etherpad.openstack.org/p/ansible-summit-october-2018

samerd commented 6 years ago

URGENT: unable to join meeting: got this error: [09:06] == Usermode change: +Ri [09:06] == gateway/web/freenode/ip.209.116.155.178 is now your hidden host (set by syn.) [09:06] == #ansible-network Cannot join channel (+r) - you need to be identified with services

please help

mattclay commented 6 years ago

@samerd Due to increases in spam in IRC, most of them now require you register.

gundalow commented 6 years ago

@samerd I've removed the requirement, please try and join again

samerd commented 6 years ago

@mattclay: thanks, I'll register ASAP

amuraleedhar commented 6 years ago

Hi,

I have registered as Anil_Lenovo. Now how can I join the chat ?

-Anil

From: John R Barker notifications@github.com Sent: Wednesday, August 01, 2018 9:51 PM To: ansible/community community@noreply.github.com Cc: Anil Kumar Muraleedharan amuraleedhar@lenovo.com; Comment comment@noreply.github.com Subject: [External] Re: [ansible/community] Network Working Group Meeting Agenda 2 (#247)

@samerdhttps://github.com/samerd I've removed the requirement, please try and join again

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/ansible/community/issues/247#issuecomment-409633027, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ANdCcnKUKh5hFgmV1MQpbs1BN8Y__Ryxks5uMdVQgaJpZM4PdkPJ.

gundalow commented 6 years ago

Ansible Contributor Summit 6 (Part of AnsibleFest 2018 Austin, Texas)

As part of http://www.ansible.com/ansiblefest

This is your event

Ansible succeeds because of its community, and this contributor summit is for you. If you have any topics to discuss, large or small, please be sure to post those topics on the etherpad. For topics that other had added please vote by adding +1

https://etherpad.openstack.org/p/ansible-summit-october-2018

Please see https://groups.google.com/forum/#!topic/ansible-devel/ivrpVbLya8g for further info

Attending in person

We realize that not everybody can attend in person, which is why we’ll again be arranging a video conference and a meeting time on IRC in #ansible-meeting to encourage remote participation. This has worked very well for the past Contributor Summits. We’ll be sending out an email with the information for remote participation about a week before the Contributor Summit.

If you want to attend in-person please sign up at: https://www.eventbrite.com/e/ansible-contributor-conference-austin-2018-tickets-48557063484

After signing up you'll receive an email from Eventbrite with a discount code for AnsibleFest Austin.

Attending remotely

Please add your name at the bottom of this etherpad: https://etherpad.openstack.org/p/ansible-summit-october-2018

Call to action

1) Add ideas to https://etherpad.openstack.org/p/ansible-summit-october-2018 2) Attending in person: https://www.eventbrite.com/e/ansible-contributor-conference-austin-2018-tickets-48557063484 then use discount code to sign up to AnsibleFest 3) Attending in person OR virtually: Add your name to the end of https://etherpad.openstack.org/p/ansible-summit-october-2018 4) Happy automating!

Questions?

Thanks for all of your contributions to Ansible, and we hope to see you in Austin! And if you have any questions at all, please let us know.

Speak to gundalow on Freenode, or anyone else in #ansible-devel

gundalow commented 6 years ago

ios_config fails when creating macro "timeout trying to send command:" https://github.com/ansible/ansible/issues/38420

amuraleedhar commented 6 years ago

Please review and merge the following PRs ansible/ansible#44398 MERGED ansible/ansible#44559 MERGED

Thanks

-Anil

yaplej commented 6 years ago

Would appreciate it if you could also look these. https://github.com/ansible/ansible/issues/43861 https://github.com/ansible/ansible/issues/43996

ganeshrn commented 6 years ago

https://github.com/ansible/ansible/pull/35817

samerd commented 6 years ago

Please merge ansible/ansible#44527

Qalthos commented 6 years ago

2018-08-29

Team status and updates

Actions

Logs

Minutes: https://meetbot.fedoraproject.org/ansible-network/2018-08-29/network_working_group.2018-08-29-16.00.html Minutes (text): https://meetbot.fedoraproject.org/ansible-network/2018-08-29/network_working_group.2018-08-29-16.00.txt Log: https://meetbot.fedoraproject.org/ansible-network/2018-08-29/network_working_group.2018-08-29-16.00.log.html

amuraleedhar commented 6 years ago

Please Merge the following PR ansible/ansible#44953 Merged

Thanks

-Anil

Qalthos commented 6 years ago

2018-09-05

Team status and updates

Logs

Minutes: https://meetbot.fedoraproject.org/ansible-network/2018-09-05/ansible_network_working_group.2018-09-05-15.59.html Minutes (text): https://meetbot.fedoraproject.org/ansible-network/2018-09-05/ansible_network_working_group.2018-09-05-15.59.txt Log: https://meetbot.fedoraproject.org/ansible-network/2018-09-05/ansible_network_working_group.2018-09-05-15.59.log.html

amuraleedhar commented 6 years ago

Please Merge the following PR ansible/ansible#45278 Merged

CLIs used in cnos_facts, cnos_command, its UT test modules and few CLI template files are in old format. This is getting corrected to new CLI format. Though we are having backward compatibility for this CLIs, it will get deprecated from 10.9 onwards. So we want to change them all to new CLI. Hence this PR is. Please merge this so that Customers will have all latest CLI experience.

Thanks

-Anil

amuraleedhar commented 6 years ago

Please Merge the following PR ansible/ansible#45483

Thanks -Anil

Qalthos commented 6 years ago

2018-09-12

Team status and updates

Logs

Minutes: https://meetbot.fedoraproject.org/ansible-network/2018-09-12/ansible_network_working_group.2018-09-12-16.00.html Minutes (text): https://meetbot.fedoraproject.org/ansible-network/2018-09-12/ansible_network_working_group.2018-09-12-16.00.txt Log: https://meetbot.fedoraproject.org/ansible-network/2018-09-12/ansible_network_working_group.2018-09-12-16.00.log.html

gundalow commented 6 years ago

Network session as part of Austin AnsibleFest Contributors Summit

We will be having a Network session which you can join in person or remotely via IRC/VideoCall

Network Agenda: https://etherpad.openstack.org/p/ansible-summit-october-2018-network Zuul Agenda: https://etherpad.openstack.org/p/ansible-summit-october-2018-zuul

Also there are two Zuul talks at Ansible Fest:

Top level Agenda: https://etherpad.openstack.org/p/ansible-summit-october-2018

Please feel free to add comments and vote (+1) on topics.

NOTE time and location of sessions may change

For more information about the Contributors Summit see https://github.com/ansible/community/issues/329#issuecomment-410040811

If you have questions feel free to ask here, in IRC, or ping gundalow.

Hope to see you there either in person or online.

pabelanger commented 6 years ago

2018-09-19

IRC logs

Minutes: https://meetbot.fedoraproject.org/ansible-network/2018-09-19/ansible_network_working_group.2018-09-19-16.02.html Minutes (text): https://meetbot.fedoraproject.org/ansible-network/2018-09-19/ansible_network_working_group.2018-09-19-16.02.txt Log: https://meetbot.fedoraproject.org/ansible-network/2018-09-19/ansible_network_working_group.2018-09-19-16.02.log.html

Qalthos commented 6 years ago

2018-09-26

Team status and updates

Team Updates

Logs

Minutes: https://meetbot.fedoraproject.org/ansible-network/2018-09-26/ansible_network_working_group.2018-09-26-16.00.html Minutes (text): https://meetbot.fedoraproject.org/ansible-network/2018-09-26/ansible_network_working_group.2018-09-26-16.00.txt Log: https://meetbot.fedoraproject.org/ansible-network/2018-09-26/ansible_network_working_group.2018-09-26-16.00.log.html