Qalthos commented 5 years ago

Please leave a comment regarding any agenda item you wish to discuss. If you don't show up for the meeting, your item will be skipped.

If your IRC nick is different from your Github username, leave that as well.

See https://github.com/ansible/community/tree/master/group-network for the schedule

All Core Networking issues (most recently updated at the top): https://github.com/ansible/ansible/issues?q=is%3Aopen+label%3Anetworking+-label%3Aneeds_revision+sort%3Aupdated-desc

Network Working Group: https://github.com/ansible/community/tree/master/group-network

ansible-network on Freenode IRC

Qalthos commented 5 years ago

@samerd commented 2 hours ago

Please welcome @anasbadaha (https://github.com/anasbadaha) a new team member of Mellanox-Onyx His first PR: ansible/ansible#46218 Please review this PR and merge if OK with you

caphrim007 commented 5 years ago

commenting on top of @dagwieers 's comment here

https://github.com/ansible/community/issues/247#issuecomment-426036653

For F5 specific stuff, we have a special token that is generated (and required to be re-used) after we auth with a user/pass. we need to put that token in a Header which we send with future requests. This token needs to be deleted at the "end of the session" too otherwise we'll eventually run out of available tokens.

So right now we establish a connection (non-httpapi) make all our calls with the token, and then delete the token upon success/fail.

We have a couple modules that also check to see if the box is online to begin with. Today this isnt a problem because we handle the connection in the module. If the connection is moved out of the module, then the httpapi connection will need to know how to deal with this. In our case, it's technically equivalent of wait_for and some other custom checks. I imagine this would be a little ugly to bake into the httpapi (or equivalent) code.

Finally, we have several modules that reboot the device and wait for it to come back online. This rebooting invalidates the token as well. We would need to be able to mimic this in httpapi (or equivalent).

dagwieers commented 5 years ago

I have started a new Wiki page to share requirements from each of the potential httpapi shareholders. https://github.com/ansible/community/wiki/Plugin:-httpapi

Feel free to add more information there.

Qalthos commented 5 years ago

@caphrim007

For F5 specific stuff, we have a special token that is generated (and required to be re-used) after we auth with a user/pass. we need to put that token in a Header which we send with future requests. This token needs to be deleted at the "end of the session" too otherwise we'll eventually run out of available tokens.

That's pretty standard. In an httpapi plugin, you can set self.connection._auth to a dictionary that gets merged with headers on every call. This would presumably get set in login() and cleared in logout(), which do what they sound like. logout() is also helpfully called during close(), so connection shutdown will clear your token for you (as will meta: reset_connection).

We have a couple modules that also check to see if the box is online to begin with.

This is one I haven't given a whole lot of thought to. I'm not entirely sure what this means, to be honest. I'm not really sure what this needs that until: "'stdout' in result" (or, more probably, some better test) doesn't give you.

Finally, we have several modules that reboot the device and wait for it to come back online. This rebooting invalidates the token as well. We would need to be able to mimic this in httpapi (or equivalent).

meta: reset_connection should be able to do just this. For persistent connections, it calls the connection's close() (which, as above, calls your httpapi plugin's logout() method).

Additionally, (and especially as a lot of the above points were requested by them), if you want to see how someone who is not me wrote an httpapi plugin to work with something that does not look anything like NX-API/eAPI (read: REST), take a look at plugins/httpapi/ftd.py. If you want to know what is expected of an httpapi plugin, the interface is described in plugins/httpapi/__init__.py, and if something still doesn't seem clear, bring it up and I'll be happy to talk about how to make it better.

@dagwieers I think this covers most of your needs as well. The major sticking point I know you still have is cluster support, and I haven't the faintest idea how to make that work in a way that doesn't ruin all the niceties that making connections look like real connection plugins. My only idea is to add a failover_hosts option to your httpapi plugin that subs out the connection's _url, but I have no idea how much trouble trying to do something like that might cause.

gundalow commented 5 years ago

Proposal: Interface manager role https://github.com/ansible-network/network-proposals/issues/1

The interface manager role provides a platform agnostic implementation to declaratively manage the aggregate set of network interfaces on a remote device. This role is designed to effectively replace the net_interface module that is currently part of Ansible core.

privateip commented 5 years ago

Proposal: VRF definitions role https://github.com/ansible-network/network-proposals/issues/3

This proposal describe the implementation of a new resource role for managing VRF definitions in network device active configurations. This role would replace the current net_vrf agnostic module that currently resides in Ansible core.

privateip commented 5 years ago

Proposal: VLANs role https://github.com/ansible-network/network-proposals/issues/2

This proposal describes the implementation of a VLANs role to replace the current platform agnostic implementation ofnet_vlan currently in Ansible core.

amuraleedhar commented 5 years ago

Please review and merge PR ansible/ansible#46623

Thanks & Regards -Anil

Qalthos commented 5 years ago

2018-10-10

Team status and updates

Ansible 2.7 was released last week!
AnsibleFest was last week as well

Actions

@privateip Update description that configure-vlan will be folded into this role
@privateip create role architecture writeup that can be linked in to role proposals to answer common questions regarding roles
@privateip describe each role option on proposals

Logs

Minutes: https://meetbot.fedoraproject.org/ansible-network/2018-10-10/ansible_network_working_group.2018-10-10-16.00.html Minutes (text): https://meetbot.fedoraproject.org/ansible-network/2018-10-10/ansible_network_working_group.2018-10-10-16.00.txt Log: https://meetbot.fedoraproject.org/ansible-network/2018-10-10/ansible_network_working_group.2018-10-10-16.00.log.html

salman1485 commented 5 years ago

Can we discuss this please on 10/17- https://github.com/ansible/ansible/issues/46185

Qalthos commented 5 years ago

2018-10-17

Team status and updates

The ansible-network team did releases this week of roles and published them on https://galaxy.ansible.com/ansible-network/
Reminder that Python 2.6 support has been removed from the ansible controller as of Ansible 2.7
- This means network modules will stop working without Python 2.7 or 3.5+

Logs

Minutes: https://meetbot.fedoraproject.org/ansible-network/2018-10-17/ansible_network_working_group.2018-10-17-16.02.html Minutes (text): https://meetbot.fedoraproject.org/ansible-network/2018-10-17/ansible_network_working_group.2018-10-17-16.02.txt Log: https://meetbot.fedoraproject.org/ansible-network/2018-10-17/ansible_network_working_group.2018-10-17-16.02.log.html

anasbadaha commented 5 years ago

Hi, I'm a new member in Mellanox onyx team. please review and merge the following PRs: ansible/ansible#46494 ansible/ansible#46500 ansible/ansible#47027 ansible/ansible#47489 ansible/ansible#47501 ansible/ansible#47552 ansible/ansible#47554

Best Regards, Anas Badaha

Qalthos commented 5 years ago

2018-10-24

Team status and updates

2.7.1 should be coming real soon
continued work on a network_configurator role for tower
adding configure_user support to cisco_iosxr provider
fixed nxos_facts bug in non-structured output
bugfix for network-engine repeat_for templating
Working with Cisco for firepower facts/install modules

Logs

Minutes: https://meetbot.fedoraproject.org/ansible-network/2018-10-24/ansible_network_working_group.2018-10-24-16.03.html Minutes (text): https://meetbot.fedoraproject.org/ansible-network/2018-10-24/ansible_network_working_group.2018-10-24-16.03.txt Log: https://meetbot.fedoraproject.org/ansible-network/2018-10-24/ansible_network_working_group.2018-10-24-16.03.log.html

justjais commented 5 years ago

2018-10-31

Team status and updates

Released VyOS provider 2.6.2 and 2.7.0. Fixed ios_user issue for password-based existing users(#47656). Added support for 25G and 100G interfaces in ios_vlan and ios_l2_interface(#47852)
working with cisco on asa firepower module, the role for network operation
working on odl integration for l3vpn use case
working on network_configurator role and nios bugs

Logs

Minutes: https://meetbot.fedoraproject.org/ansible-network/2018-10-31/ansible_network_working_group.2018-10-31-15.57.html 10:29 PM Minutes (text): https://meetbot.fedoraproject.org/ansible-network/2018-10-31/ansible_network_working_group.2018-10-31-15.57.txt Log: https://meetbot.fedoraproject.org/ansible-network/2018-10-31/ansible_network_working_group.2018-10-31-15.57.log.html

abenokraitis commented 5 years ago

2018-11-07

Team status and updates

Ansible 2.8 roadmap still in progress: https://github.com/ansible/ansible/blob/devel/docs/docsite/rst/roadmap/ROADMAP_2_8.rst

Logs

mikewiebe commented 5 years ago

Need the following PR Merged:

~~https://github.com/ansible/ansible/pull/47944~~ Merged

Qalthos commented 5 years ago

2018-11-14

Team status and updates

worked on tower lookup plugin removing tower_cli dependency
juniper_junos 2.6.2 and 2.7.0 released
cisco_nxos 2.6.2 and 2.7.0 released - updates load function to use cli_config module.
work on adding network_cli, netconf, httapi connection session tracing capability

Logs

Minutes: https://meetbot.fedoraproject.org/ansible-network/2018-11-14/ansible_network_working_group.2018-11-14-16.00.html Minutes (text): https://meetbot.fedoraproject.org/ansible-network/2018-11-14/ansible_network_working_group.2018-11-14-16.00.txt Log: https://meetbot.fedoraproject.org/ansible-network/2018-11-14/ansible_network_working_group.2018-11-14-16.00.log.html

amuraleedhar commented 5 years ago

Need the following PR Merged: ansible/ansible#48924 - MERGED ansible/ansible#48154 - MERGED

Qalthos commented 5 years ago

2018-11-28

Team status and updates

Fixed nxos_facts neighbors issues
Network interface role proposal for nxos
Released juniper_junos v2.7.1
work in progress to add get function to yang role
Released VyOS provider 2.7.1
Released cisco_ios 2.6.3
system property role and iosxr lldp role
add session tracing feature for network_cli
Ansible 2.7.2 was released Logs

Minutes: https://meetbot.fedoraproject.org/ansible-network/2018-11-28/ansible_network_working_group.2018-11-28-16.06.html Minutes (text): https://meetbot.fedoraproject.org/ansible-network/2018-11-28/ansible_network_working_group.2018-11-28-16.06.txt Log: https://meetbot.fedoraproject.org/ansible-network/2018-11-28/ansible_network_working_group.2018-11-28-16.06.log.html

amuraleedhar commented 5 years ago

Please merge ~~ansible/ansible#49467~~ Merged

mikewiebe commented 5 years ago

Please cherry-pick the following bug fix PR's into stable2.7

https://github.com/ansible/ansible/pull/49479 https://github.com/ansible/ansible/pull/49454 https://github.com/ansible/ansible/pull/49314 https://github.com/ansible/ansible/pull/49205 https://github.com/ansible/ansible/pull/49150 https://github.com/ansible/ansible/pull/48811 https://github.com/ansible/ansible/pull/47694

pabelanger commented 5 years ago

2018-12-05

Action items @pabelanger review backport request from mikewiebe: https://github.com/ansible/community/issues/363#issuecomment-444546695

-- Minutes: https://meetbot.fedoraproject.org/ansible-network/2018-12-05/ansible_network_working_group.2018-12-05-16.01.html Minutes (text): https://meetbot.fedoraproject.org/ansible-network/2018-12-05/ansible_network_working_group.2018-12-05-16.01.txt Log: https://meetbot.fedoraproject.org/ansible-network/2018-12-05/ansible_network_working_group.2018-12-05-16.01.log.html

Qalthos commented 5 years ago

2018-12-12

Team status and updates

cisco_ios 2.7.0 was released
cisco_iosxr 2.7.1 was released
network_engine 2.7.2 was released
working with skydive network topologies
Worked on ansible_facts generation with gather_facts for network platforms.
Updated nxapi & eapi httpapi plugins to be more in-line with how httpapi plugins are expected to work

Actions

~~@Qalthos follow-up on ansible/ansible#46773~~ Merged

Logs

Minutes: https://meetbot.fedoraproject.org/ansible-network/2018-12-12/ansible_network_working_group.2018-12-12-16.01.html Minutes (text): https://meetbot.fedoraproject.org/ansible-network/2018-12-12/ansible_network_working_group.2018-12-12-16.01.txt Log: https://meetbot.fedoraproject.org/ansible-network/2018-12-12/ansible_network_working_group.2018-12-12-16.01.log.html

amuraleedhar commented 5 years ago

Please merge PR ~~ansible/ansible#49927~~ Merged ansible/ansible#50145

lvrfrc87 commented 5 years ago

New IOS NTP module.

- ios_ntp:
    server: 8.8.9.9
    source_int: Loopback0
    acl: NTP_ACL
    logging: true
    key_id: 10
    auth_key: 15435A030726242723273C21181319000A
    auth: true
    state: absent
    provider: "{{ staging }}"

https://github.com/ansible/ansible/pull/49894

Qalthos commented 5 years ago

2018-12-19

Team status and updates

Ported vyos provider load & replace to use cli_command and cli_config
Working on vyos_ping module
Ansible 2.7.5 was released last Thursday
No more IRC meetings until 2019-01-02

Actions

@FedericoOlivieri add tests to ios_ntp PR

Logs

Minutes: https://meetbot.fedoraproject.org/ansible-network/2018-12-19/ansible_network_working_group.2018-12-19-16.00.html Minutes (text): https://meetbot.fedoraproject.org/ansible-network/2018-12-19/ansible_network_working_group.2018-12-19-16.00.txt Log: https://meetbot.fedoraproject.org/ansible-network/2018-12-19/ansible_network_working_group.2018-12-19-16.00.log.html

amuraleedhar commented 5 years ago

Please merge PR ~ansible/ansible#50145 - Review comments Done~ Merged ~ansible/ansible#50641 - New Module~ Merged

ganeshrn commented 5 years ago

https://github.com/ansible/ansible/pull/50801

Qalthos commented 5 years ago

2019-01-16

Team status and updates

more work on integrating facts gathering
fixes to vyos' get_config missing parameters
nxos_install_os timeout fix
refactor to config modules to allow specifying backup location

Actions

anyone with a _config network module review ansible/ansible#50801 and raise concerns

Logs

Minutes: https://meetbot.fedoraproject.org/ansible-network/2019-01-16/ansible_network_working_group.2019-01-16-15.59.html Minutes (text): https://meetbot.fedoraproject.org/ansible-network/2019-01-16/ansible_network_working_group.2019-01-16-15.59.txt Log: https://meetbot.fedoraproject.org/ansible-network/2019-01-16/ansible_network_working_group.2019-01-16-15.59.log.html

mikewiebe commented 5 years ago

@Qalthos Which nxos_install_os timeout fix in the 2019-01-16 update are you referring to? Sorry, was not able to attend the meeting.

trishnaguha commented 5 years ago

@Qalthos Which nxos_install_os timeout fix in the 2019-01-16 update are you referring to? Sorry, was not able to attend the meeting.

@mikewiebe https://github.com/ansible/ansible/pull/50965

lvrfrc87 commented 5 years ago

https://github.com/ansible/ansible/pull/50705

Qalthos commented 5 years ago

2019-01-23

Team status and updates

vyos provider v2.7.3 released
Fixed ansible_connect_timeout being passed as extra vars
More work on network facts gathering for 2.8
Added terminal and cliconf plugins for Free Range Routing platform.
Added multiple public keys support for ios_user
Fixed cisco_ios provider issue - ansible-network/cisco_ios#86

Actions

~~merge ansible/ansible#50801~~ Merged
~~@Qalthos distill comments on ansible/ansible#50705 into a PR review~~ Added

Logs

Minutes: https://meetbot.fedoraproject.org/ansible-network/2019-01-23/ansible_network_working_group.2019-01-23-16.00.html Minutes (text): https://meetbot.fedoraproject.org/ansible-network/2019-01-23/ansible_network_working_group.2019-01-23-16.00.txt Log: https://meetbot.fedoraproject.org/ansible-network/2019-01-23/ansible_network_working_group.2019-01-23-16.00.log.html

amuraleedhar commented 5 years ago

Please merge PR ~~ansible/ansible#51322~~ Merged

lvrfrc87 commented 5 years ago

~~https://github.com/ansible/ansible/pull/50705 Add the changes required. Need review before merge.~~ Merged

Qalthos commented 5 years ago

2019-01-30

Team status and updates

Facts gathering 2.8 work is almost done ansible/ansible#51434
Moved verify_dependent_role_version plugin to network engine from cisco_ios role ansible-network/network-engine#214
Continued work on cloud_vpn facts and provisioning on existing VPCs
Added option to enter admin configuration mode in iosxr_user module ansible/ansible#51430
New module junos_ping merged in devel

Logs

Minutes: https://meetbot.fedoraproject.org/ansible-network/2019-01-30/ansible_network_working_group.2019-01-30-15.59.html Minutes (text): https://meetbot.fedoraproject.org/ansible-network/2019-01-30/ansible_network_working_group.2019-01-30-15.59.txt Log: https://meetbot.fedoraproject.org/ansible-network/2019-01-30/ansible_network_working_group.2019-01-30-15.59.log.html

Qalthos commented 5 years ago

2019-02-06

Team status and updates

Released network engine 2.7.3
Removed irrelevant vn-segment command on nxos vlan deletion ansible/ansible#51796
Added license_hostid to nxos_facts ansible/ansible#51588
Work in progress for grpc connection plugin

Logs

Minutes: https://meetbot.fedoraproject.org/ansible-network/2019-02-06/ansible_network_working_group.2019-02-06-16.00.html Minutes (text): https://meetbot.fedoraproject.org/ansible-network/2019-02-06/ansible_network_working_group.2019-02-06-16.00.txt Log: https://meetbot.fedoraproject.org/ansible-network/2019-02-06/ansible_network_working_group.2019-02-06-16.00.log.html

Qalthos commented 5 years ago

2019-02-13

Team status and updates

working on cisco ftd use case via ansible module
- Use cases not complete, will be spelled out in feature request issue
working on various cloud vpn provider fixes and spoke/hub scenarios
Worked on a deploy/setup function for FRR
Finished frr_facts module

Logs

Minutes: https://meetbot.fedoraproject.org/ansible-network/2019-02-13/ansible_network_working_group.2019-02-13-16.00.html Minutes (text): https://meetbot.fedoraproject.org/ansible-network/2019-02-13/ansible_network_working_group.2019-02-13-16.00.txt Log: https://meetbot.fedoraproject.org/ansible-network/2019-02-13/ansible_network_working_group.2019-02-13-16.00.log.html

yaplej commented 5 years ago

Please review. ansible/ansible#43996 ansible/ansible#43861

amuraleedhar commented 5 years ago

Please review and merge ~~ansible/ansible#52568~~ Merged

Qalthos commented 5 years ago

2019-02-20

Team status and updates

ios_bgp work completed (ansible/ansible#49121)
eos_bgp work started
Fail validate_role_spec plugin if argument_spec is undefined (ansible-network/network-engine#221)
Fix relative path failure in command_parser (ansible-network/network-engine#222)
Released network engine 2.7.4 and 2.6.10

Actions

~~@Qalthos review ansible/ansible#52568~~ Merged
@Qalthos ping ganeshrn about handling control chars in ios_config diff
@Qalthos look into NetworkConfig comment_tokens

Logs

Minutes: https://meetbot.fedoraproject.org/ansible-network/2019-02-20/ansible_network_working_group.2019-02-20-15.59.html Minutes (text): https://meetbot.fedoraproject.org/ansible-network/2019-02-20/ansible_network_working_group.2019-02-20-15.59.txt Log: https://meetbot.fedoraproject.org/ansible-network/2019-02-20/ansible_network_working_group.2019-02-20-15.59.log.html

lvrfrc87 commented 5 years ago

https://github.com/ansible/ansible/pull/52925

New ASA module for object-group keeping:

---
vars:
  config_list:
    - range 56832 56959
    - range 61363 65185

- name: configure UDP object-group service with port-object
  asa_og:
    name: service_object_test
    group_type: port-object
    protocol: udp
    lines: "{{ item }}"
    provider: "{{ fws }}"
  register: result
  loop:
    - "{{ config_list }}"

amuraleedhar commented 5 years ago

Please review and merge ~~ansible/ansible#52978~~ Merged

mikewiebe commented 5 years ago

Please review:

https://github.com/ansible/ansible/pull/52883

bhansalij21 commented 5 years ago

Please review ansible/ansible#51238

Qalthos commented 5 years ago

2019-02-27

Team status and updates

added keypair management to cloud vpn provisioners
working on saving tunnels facts when processing lists of tunnel configs
Included support of Cisco_ftd under acl_manager role
gRPC connection plugin added (ansible/ansible#52823)
grpc_nw_get module to work with iosxr 9k (ansible/ansible#52857)
restconf_config module (ansible/ansible#51971)

Logs

Minutes: https://meetbot.fedoraproject.org/ansible-network/2019-02-27/ansible_network_working_group.2019-02-27-16.00.html Minutes (text): https://meetbot.fedoraproject.org/ansible-network/2019-02-27/ansible_network_working_group.2019-02-27-16.00.txt Log: https://meetbot.fedoraproject.org/ansible-network/2019-02-27/ansible_network_working_group.2019-02-27-16.00.log.html

amuraleedhar commented 5 years ago

Please review and merge ~~ansible/ansible#53267~~ Merged

grastogi23 commented 5 years ago

Please review and merge ~~https://github.com/ansible/ansible/pull/52661~~ Merged

Qalthos commented 5 years ago

2019-03-06

Team status and updates

Released Network Engine 2.7.5 - Bugfix (ansible-network/network-engine#230)

Actions

~~@Qalthos follow up on ansible/ansible#52661~~ Merged
@Qalthos follow up on ansible/ansible#51238
@smolz Add unit tests to ansible/ansible#52892

Logs

Minutes: https://meetbot.fedoraproject.org/ansible-network/2019-03-06/ansible_network_working_group.2019-03-06-16.03.html Minutes (text): https://meetbot.fedoraproject.org/ansible-network/2019-03-06/ansible_network_working_group.2019-03-06-16.03.txt Log: https://meetbot.fedoraproject.org/ansible-network/2019-03-06/ansible_network_working_group.2019-03-06-16.03.log.html

amuraleedhar commented 5 years ago

Please review and merge ~~ansible/ansible#53736~~ Merged ~~ansible/ansible#53764~~ Merged

ansible / community

Network Working Group Meeting Agenda 3 #363

ansible-network on Freenode IRC

2018-10-10

Team status and updates

Actions

Logs

2018-10-17

Team status and updates

Logs

2018-10-24

Team status and updates

Logs

2018-10-31

Team status and updates

Logs

2018-11-07

Team status and updates

Logs

2018-11-14

Team status and updates

Logs

2018-11-28

Team status and updates

Ansible 2.7.2 was released Logs

2018-12-05

2018-12-12

Team status and updates

Actions

Logs

2018-12-19

Team status and updates

Actions

Logs

2019-01-16

Team status and updates

Actions

Logs

2019-01-23

Team status and updates

Actions

Logs

2019-01-30

Team status and updates

Logs

2019-02-06

Team status and updates

Logs

2019-02-13

Team status and updates

Logs

2019-02-20

Team status and updates

Actions

Logs

2019-02-27

Team status and updates

Logs

2019-03-06

Team status and updates

Actions

Logs