Closed nitzmahone closed 3 years ago
--limit
should raise an error (or at least be no-op)plugin_utils
discussionMeeting ended Tue Nov 10 20:00:26 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . 3:00 PM Minutes: https://meetbot.fedoraproject.org/ansible-meeting/2020-11-10/ansible_core_public_irc_meeting.2020-11-10-19.00.html 3:00 PM Minutes (text): https://meetbot.fedoraproject.org/ansible-meeting/2020-11-10/ansible_core_public_irc_meeting.2020-11-10-19.00.txt 3:00 PM Log: https://meetbot.fedoraproject.org/ansible-meeting/2020-11-10/ansible_core_public_irc_meeting.2020-11-10-19.00.log.html
Meeting ended Thu Nov 12 15:28:56 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . New messages 10:28 AM Minutes: https://meetbot.fedoraproject.org/ansible-meeting/2020-11-12/ansible_core_public_irc_meeting.2020-11-12-15.01.html 10:28 AM Minutes (text): https://meetbot.fedoraproject.org/ansible-meeting/2020-11-12/ansible_core_public_irc_meeting.2020-11-12-15.01.txt 10:28 AM Log: https://meetbot.fedoraproject.org/ansible-meeting/2020-11-12/ansible_core_public_irc_meeting.2020-11-12-15.01.log.html
EDIT: nothing special about 3.9 here, every pip has done that for a long time- we want to maintain the build-time warning to uninstall 2.9, but that's likely the last remaining thing blocking us from shipping an arch-agnostic wheel. fallible
will always be wheels, and we'll likely bring that back to ansible-core
in 2.11++
Meeting ended Tue Nov 17 19:11:48 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . 11:11 AM Minutes: https://meetbot.fedoraproject.org/ansible-meeting/2020-11-17/ansible_core_public_irc_meeting.2020-11-17-19.00.html 11:11 AM Minutes (text): https://meetbot.fedoraproject.org/ansible-meeting/2020-11-17/ansible_core_public_irc_meeting.2020-11-17-19.00.txt 11:11 AM Log: https://meetbot.fedoraproject.org/ansible-meeting/2020-11-17/ansible_core_public_irc_meeting.2020-11-17-19.00.log.html
Meeting ended Thu Nov 19 16:01:19 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . Minutes: https://meetbot.fedoraproject.org/ansible-meeting/2020-11-19/ansible_core_public_irc_meeting.2020-11-19-15.00.html Minutes (text): https://meetbot.fedoraproject.org/ansible-meeting/2020-11-19/ansible_core_public_irc_meeting.2020-11-19-15.00.txt Log: https://meetbot.fedoraproject.org/ansible-meeting/2020-11-19/ansible_core_public_irc_meeting.2020-11-19-15.00.log.html
BaseFileCacheModule
(the base class for file-based cache modules) puts out a warning whenever the cache file (which it's about to create for the first time) doesn't exist. There's no way to configure it currently. The warning is not really useful or actionable imo, because again it's just going to get created anyway.Edit: alternative proposed: use v()
instead of warning()
.
I think that a non-existent file should be ignored (and in fact in the same class, in the has_expired
method, that is exactly what is done). Failing that, I think it should be end-user configurable so it can be turned off.
I'd be happy to take the time to put in a PR for this, but it's core code, in a base class, so I know it's going to have a lot of scrutiny and I want to test the waters before I put that in only to have it closed. So looking for some thoughts from core devs on whether we could change this, preferred way to approach, etc.
For reference: this is where the warning on a missing file is generated (in the get
method): https://github.com/ansible/ansible/blob/35022e13a839d5f59a1c4a254aca12afb124373a/lib/ansible/plugins/cache/__init__.py#L170
This is where the same condition is ignored in has_expired
: https://github.com/ansible/ansible/blob/35022e13a839d5f59a1c4a254aca12afb124373a/lib/ansible/plugins/cache/__init__.py#L196
Edit: Also seems there's already a PR for this, but unclear why it hasn't been merged: https://github.com/ansible/ansible/pull/57646
Edit2: there's a new PR addressing this for inventory caching: https://github.com/ansible/ansible/pull/72840
NOTE: no core meetings week of Nov 23-27 (US holidays)
Meeting ended Tue Dec 1 19:22:30 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . Minutes: https://meetbot.fedoraproject.org/ansible-meeting/2020-12-01/ansible_core_public_irc_meeting.2020-12-01-19.00.html Minutes (text): https://meetbot.fedoraproject.org/ansible-meeting/2020-12-01/ansible_core_public_irc_meeting.2020-12-01-19.00.txt Log: https://meetbot.fedoraproject.org/ansible-meeting/2020-12-01/ansible_core_public_irc_meeting.2020-12-01-19.00.log.html
Meeting ended Thu Dec 3 15:51:20 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . Minutes: https://meetbot.fedoraproject.org/ansible-meeting/2020-12-03/ansible_core_public_irc_meeting.2020-12-03-15.00.html Minutes (text): https://meetbot.fedoraproject.org/ansible-meeting/2020-12-03/ansible_core_public_irc_meeting.2020-12-03-15.00.txt Log: https://meetbot.fedoraproject.org/ansible-meeting/2020-12-03/ansible_core_public_irc_meeting.2020-12-03-15.00.log.html
RFC on implementation ideas:
Edit from sivel:
PoC for a change to vars
lookup to handle this: https://github.com/ansible/ansible/pull/72885
edit from nitzmahone
nytelife26 to try "just make it fail" approach with a ci_complete
run to see if it's really that easy
Meeting ended Tue Dec 8 19:29:27 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . Minutes: https://meetbot.fedoraproject.org/ansible-meeting/2020-12-08/ansible_core_public_irc_meeting.2020-12-08-19.00.html Minutes (text): https://meetbot.fedoraproject.org/ansible-meeting/2020-12-08/ansible_core_public_irc_meeting.2020-12-08-19.00.txt Log: https://meetbot.fedoraproject.org/ansible-meeting/2020-12-08/ansible_core_public_irc_meeting.2020-12-08-19.00.log.html
Meeting ended Thu Dec 10 15:55:28 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . Minutes: https://meetbot.fedoraproject.org/ansible-meeting/2020-12-10/ansible_core_public_irc_meeting.2020-12-10-15.00.html Minutes (text): https://meetbot.fedoraproject.org/ansible-meeting/2020-12-10/ansible_core_public_irc_meeting.2020-12-10-15.00.txt Log: https://meetbot.fedoraproject.org/ansible-meeting/2020-12-10/ansible_core_public_irc_meeting.2020-12-10-15.00.log.html
Meeting ended Tue Jan 5 20:02:12 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . Minutes: https://meetbot.fedoraproject.org/ansible-meeting/2021-01-05/ansible_core_public_irc_meeting.2021-01-05-19.07.html Minutes (text): https://meetbot.fedoraproject.org/ansible-meeting/2021-01-05/ansible_core_public_irc_meeting.2021-01-05-19.07.txt Log: https://meetbot.fedoraproject.org/ansible-meeting/2021-01-05/ansible_core_public_irc_meeting.2021-01-05-19.07.log.html
Please leave a comment regarding any agenda item you wish to discuss. If you don't show up for the meeting, your item will be skipped. If your IRC nick is different from your Github username, leave that as well.
See https://github.com/ansible/community/blob/master/meetings/README.md for the schedule
Once an item has been discussed it should get checked off.
If you just want reviewers for your contribution try the #ansible-devel irc channel on freenode