bcoca commented 2 years ago

Please leave a comment regarding any agenda item you wish to discuss. If you don't show up for the meeting, your item will be skipped. If your IRC nick is different from your Github username, leave that as well. See https://github.com/ansible/community/blob/master/meetings/README.md for the schedule

Once an item has been discussed it should get checked off.

If you just want reviewers for your contribution try the #ansible-devel irc channel on libera.chat

bcoca commented 2 years ago

Meeting ended Tue Nov 2 19:33:52 2021 UTC. Information about Zodbot's MeetBot at https://fedoraproject.org/wiki/Zodbot#Meeting_Functions . Minutes: https://meetbot.fedoraproject.org/ansible-meeting/2021-11-02/core_public_irc_meeting.2021-11-02-19.03.html Minutes (text): https://meetbot.fedoraproject.org/ansible-meeting/2021-11-02/core_public_irc_meeting.2021-11-02-19.03.txt Log: https://meetbot.fedoraproject.org/ansible-meeting/2021-11-02/core_public_irc_meeting.2021-11-02-19.03.log.html

bcoca commented 2 years ago

Goneri (moved from last month due to PTO)

[x] https://github.com/ansible/ansible/pull/76113

felixfontein commented 2 years ago

[x] https://github.com/ansible/ansible/pull/76262 Add support to validate-modules which checks documentation markup (M(...) and some friends). This already exposed broken docs in some collections, and would have also exposed https://github.com/ansible/ansible/pull/76202 if it hadn't already been fixed. (Antsibull now ignores M(...) where the content is not similar enough to a FQCN, and according to the docs team this made ~150 docs build warnings go away. A certain amount of these will likely be issues exposed by this PR.)

evgeni commented 2 years ago

[x] https://github.com/ansible/ansible/issues/56504 https://github.com/ansible/ansible/pull/76277

(IRC: Zhenech)

s-hertel commented 2 years ago

Meeting ended Thu Nov 11 15:39:51 2021 UTC. Information about Zodbot's MeetBot at https://fedoraproject.org/wiki/Zodbot#Meeting_Functions . Minutes: https://meetbot.fedoraproject.org/ansible-meeting/2021-11-11/ansible_core_public_irc_meeting.2021-11-11-15.00.html Minutes (text): https://meetbot.fedoraproject.org/ansible-meeting/2021-11-11/ansible_core_public_irc_meeting.2021-11-11-15.00.txt Log: https://meetbot.fedoraproject.org/ansible-meeting/2021-11-11/ansible_core_public_irc_meeting.2021-11-11-15.00.log.html

lilatomic commented 2 years ago

Type hinting in ansible-core

It was brought up that we hadn't decided how we would be hinting types in ansible-core. I think the issue is simplified considerably with ansible-core dropping support for Python versions which do not support the PEP484 type hints.

For me, the biggest advantage of type hints is that I can know what type I should expect function arguments or class attributes to be without having to trace their creation. Ansible solves complicated problems, and sometimes tracing where something is created to show which class it is instantiated from can involve moving up several classes through about a dozen functions.

Pros:

know the types of function arguments and class attributes without having to traverse the codebase
can help you spot silly errors (like forgetting to access elements of a tuple)

Cons:

more things to type
noisy
sometimes type hints aren't useful because of dynamic objects
some type-hints have compatibility issues (TypedDict is the one which comes to mind, it wasn't available in 3.6 and required a conditional import of typing-extensions)

I think we can mitigate the cons by only putting type hints where they're useful. I think a good definition of "useful" in this case is where someone thought to add them or to request them.

TL;DR: I think we should allow the use of PEP484 type hints in ansible-core

(this is my first time adding an item to the agenda, LMK if there are things I can improve)

Summary from the IRC meeting:

We're going to discuss this in detail on Nov 30th (the next IRC meeting that doesn't conflict with a US holiday).
nitzmahone is going to post a list of options with some pros and cons prior to the meeting. The proposal lives at https://github.com/ansible/proposals/issues/202 - may not have a quorum at the Nov 30 meeting to discuss, but it's there for comment.

Here's a demo mattclay put together so we can discuss something concrete: https://github.com/ansible/ansible/pull/76332

s-hertel commented 2 years ago

Meeting ended Tue Nov 16 20:16:34 2021 UTC. Information about Zodbot's MeetBot at https://fedoraproject.org/wiki/Zodbot#Meeting_Functions . Minutes: https://meetbot.fedoraproject.org/ansible-meeting/2021-11-16/ansible_core_public_irc_meeting.2021-11-16-19.00.html Minutes (text): https://meetbot.fedoraproject.org/ansible-meeting/2021-11-16/ansible_core_public_irc_meeting.2021-11-16-19.00.txt Log: https://meetbot.fedoraproject.org/ansible-meeting/2021-11-16/ansible_core_public_irc_meeting.2021-11-16-19.00.log.html

felixfontein commented 2 years ago

[ ] https://github.com/ansible/ansible/pull/71734

bcoca commented 2 years ago

summary: no discussion, but now have proposal for type hints

Meeting ended Tue Nov 30 19:35:47 2021 UTC. Information about Zodbot's MeetBot at https://fedoraproject.org/wiki/Zodbot#Meeting_Functions . Minutes: https://meetbot.fedoraproject.org/ansible-meeting/2021-11-30/ansible_core_irc_meeting.2021-11-30-19.19.html Minutes (text): https://meetbot.fedoraproject.org/ansible-meeting/2021-11-30/ansible_core_irc_meeting.2021-11-30-19.19.txt Log: https://meetbot.fedoraproject.org/ansible-meeting/2021-11-30/ansible_core_irc_meeting.2021-11-30-19.19.log.html

ansible / community

Public Ansible Core Meeting Agenda - Novembre 2021 #635

Type hinting in ansible-core