ansible / django-ansible-base

Apache License 2.0
11 stars 43 forks source link

Process hub auditor role #477

Closed newswangerd closed 2 months ago

mabashian commented 2 months ago

From @jctanner: if the auditor is added to a team and tries to auth an Internal Server Error is thrown. We should track that down before merge

jctanner commented 2 months ago

Based on conversations in slack, the traceback I was seeing related to the "Default" organization is expected if the migrate_service_data command hasn't yet been run to sync the ansible_ids across the platform.

pulp-1          |   File "/src/django-ansible-base/ansible_base/jwt_consumer/common/auth.py", line 293, in authenticate
pulp-1          |     self.process_permissions()
pulp-1          |   File "/src/django-ansible-base/ansible_base/jwt_consumer/hub/auth.py", line 33, in process_permissions
pulp-1          |     team = self.common_auth.get_or_create_resource('team', team_data)[1]
pulp-1          |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
pulp-1          |   File "/src/django-ansible-base/ansible_base/jwt_consumer/common/auth.py", line 255, in get_or_create_resource
pulp-1          |     org_resource, _ = self.get_or_create_resource("organization", organization_data)
pulp-1          |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
pulp-1          |   File "/src/django-ansible-base/ansible_base/jwt_consumer/common/auth.py", line 269, in get_or_create_resource
pulp-1          |     resource = Resource.create_resource(
pulp-1          |                ^^^^^^^^^^^^^^^^^^^^^^^^^
pulp-1          |   File "/src/django-ansible-base/ansible_base/resource_registry/models/resource.py", line 110, in create_resource
pulp-1          |     content_object = processor(ObjModel()).save(resource_data, is_new=True)
pulp-1          |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
pulp-1          |   File "/src/django-ansible-base/ansible_base/resource_registry/utils/resource_type_processor.py", line 40, in save
pulp-1          |     self.instance.save()
pulp-1          |   File "/usr/lib64/python3.11/contextlib.py", line 81, in inner
pulp-1          |     return func(*args, **kwds)
pulp-1          |            ^^^^^^^^^^^^^^^^^^^
pulp-1          |   File "/usr/local/lib/python3.11/site-packages/django_lifecycle/mixins.py", line 192, in save
pulp-1          |     save(*args, **kwargs)
pulp-1          |   File "/src/django-ansible-base/ansible_base/lib/abstract_models/common.py", line 156, in save
pulp-1          |     return super().save(*args, **kwargs)
pulp-1          |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
pulp-1          |   File "/src/django-ansible-base/ansible_base/lib/abstract_models/common.py", line 133, in save
pulp-1          |     return super().save(*args, **kwargs)
pulp-1          |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
pulp-1          |   File "/src/django-ansible-base/ansible_base/lib/abstract_models/common.py", line 101, in save
pulp-1          |     return super().save(*args, **kwargs)
pulp-1          |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
pulp-1          |   File "/usr/local/lib/python3.11/site-packages/django/db/models/base.py", line 814, in save
pulp-1          |     self.save_base(
pulp-1          |   File "/usr/local/lib/python3.11/site-packages/django/db/models/base.py", line 877, in save_base
pulp-1          |     updated = self._save_table(
pulp-1          |               ^^^^^^^^^^^^^^^^^
pulp-1          |   File "/usr/local/lib/python3.11/site-packages/django/db/models/base.py", line 1020, in _save_table
pulp-1          |     results = self._do_insert(
pulp-1          |               ^^^^^^^^^^^^^^^^
pulp-1          |   File "/usr/local/lib/python3.11/site-packages/django/db/models/base.py", line 1061, in _do_insert
pulp-1          |     return manager._insert(
pulp-1          |            ^^^^^^^^^^^^^^^^
pulp-1          |   File "/usr/local/lib/python3.11/site-packages/django/db/models/manager.py", line 87, in manager_method
pulp-1          |     return getattr(self.get_queryset(), name)(*args, **kwargs)
pulp-1          |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
pulp-1          |   File "/usr/local/lib/python3.11/site-packages/django/db/models/query.py", line 1805, in _insert
pulp-1          |     return query.get_compiler(using=using).execute_sql(returning_fields)
pulp-1          |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
pulp-1          |   File "/usr/local/lib/python3.11/site-packages/django/db/models/sql/compiler.py", line 1822, in execute_sql
pulp-1          |     cursor.execute(sql, params)
pulp-1          |   File "/usr/local/lib/python3.11/site-packages/django/db/backends/utils.py", line 102, in execute
pulp-1          |     return super().execute(sql, params)
pulp-1          |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
pulp-1          |   File "/usr/local/lib/python3.11/site-packages/django/db/backends/utils.py", line 67, in execute
pulp-1          |     return self._execute_with_wrappers(
pulp-1          |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
pulp-1          |   File "/usr/local/lib/python3.11/site-packages/django/db/backends/utils.py", line 80, in _execute_with_wrappers
pulp-1          |     return executor(sql, params, many, context)
pulp-1          |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
pulp-1          |   File "/usr/local/lib/python3.11/site-packages/django/db/backends/utils.py", line 84, in _execute
pulp-1          |     with self.db.wrap_database_errors:
pulp-1          |   File "/usr/local/lib/python3.11/site-packages/django/db/utils.py", line 91, in __exit__
pulp-1          |     raise dj_exc_value.with_traceback(traceback) from exc_value
pulp-1          |   File "/usr/local/lib/python3.11/site-packages/django/db/backends/utils.py", line 89, in _execute
pulp-1          |     return self.cursor.execute(sql, params)
pulp-1          |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
pulp-1          |   File "/usr/local/lib/python3.11/site-packages/psycopg/cursor.py", line 732, in execute
pulp-1          |     raise ex.with_traceback(None)
pulp-1          | django.db.utils.IntegrityError: duplicate key value violates unique constraint "galaxy_organization_name_key"
pulp-1          | DETAIL:  Key (name)=(Default) already exists.
sonarcloud[bot] commented 2 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
46.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud