ansible / django-ansible-base

Apache License 2.0
11 stars 43 forks source link

Split assignment setting from other setting #484

Closed AlanCoding closed 2 months ago

AlanCoding commented 2 months ago

This will default to True, so the near-term plan to fix some problems we're having will be to let it assume the default value.

This will allow clients to assign permissions in the local (following) server so that it can drift from the provider server's role assignments... for lack of a better solution.

AAP-25541

bzwei commented 2 months ago

Can this PR be merged? It blocks AAP-25541 which itself is a blocker. @AlanCoding Does EDA needs to set ANSIBLE_BASE_ALLOW_LOCAL_RESOURCE_ASSIGNMENTS to True in its settings?

AlanCoding commented 2 months ago

Does EDA needs to set ANSIBLE_BASE_ALLOW_LOCAL_RESOURCE_ASSIGNMENTS to True in its settings?

By introducing a new setting here, eda-server will not have any override value, so it'll take the default of True, that's my intention.

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
75.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

AlanCoding commented 2 months ago

Talking it over with @chrismeyersfsu and others, I agree I don't want to merge this. This will regress other things and pose much risk for the future.

AlanCoding commented 2 months ago

Looking at John's comment

Do we need follow up PRs for the services?

I think this led to a number of mis-understandings. We need to enable this setting, but we also need to disable it. There's a conflict, and this isn't fixing the core tension.