Allow managing org roles with view permission locally

AlanCoding commented 2 months ago

Modifies work in https://github.com/ansible/django-ansible-base/pull/430

This replaces https://github.com/ansible/django-ansible-base/pull/484, which I put up because I did not have the full details of what was happening.

We are getting unintended errors because organization-level roles contain the "shared.view_organization" permission. So this change will wave those through.

This means that some access evaluations will give a different answer on different servers in some cases (can I view this organization?). If that is restricted to viewing permission of parent objects, that appears manageable.

AAP-25541

bzwei commented 2 months ago

The logic makes sense. LGTM

sonarcloud[bot] commented 2 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

ansible / django-ansible-base

Allow managing org roles with view permission locally #501

Quality Gate passed