ansible / django-ansible-base

Apache License 2.0
12 stars 43 forks source link

Nest the dynamic settings inclusion into a method #531

Closed AlanCoding closed 1 month ago

AlanCoding commented 1 month ago

Alternative to https://github.com/ansible/django-ansible-base/pull/526

Well, it's not really an alternative, we could do both of them (a module for static settings & a module for function-ified settings), but this would also address our immediate problem.

Overall idea:

This puts most of our existing logic around dynamic settings into a method get_dab_settings. This keeps the canonical method of including settings, this just adds another layer internally. Benefits:

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud