ansible / django-ansible-base

Apache License 2.0
18 stars 49 forks source link

fix(lib.validation): properly validate ca-signed keypairs #652

Closed BrennanPaciorek closed 2 days ago

BrennanPaciorek commented 3 days ago

Change the mechanism we use to validate keypairs to not assume that a certificate is self-signed. This causes some valid keypairs to fail.

Testing steps:

AAP-33294

BrennanPaciorek commented 3 days ago

Sonar cloud output seems bugged, maybe it expects test to be committed after? If it fails again, I'll reorder the commits.

sonarcloud[bot] commented 3 days ago

Quality Gate Passed Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

john-westcott-iv commented 3 days ago

We might want to exclude lib/testsing/fixtures.py from the sonar analysis. This can be done in= sonar-project.properties. @relrod, any thoughts on this?