ansible / eda-server

Event Driven Ansible for AAP
Apache License 2.0
64 stars 41 forks source link

feat: add prefix to redis keys #897

Closed bzwei closed 3 months ago

bzwei commented 3 months ago

Monkey patch originally hardcoded redis keys used by rq and rq-scheduler to have EDA{uuid} prefix to avoid conflicts in a centralized redis env.

AAP-22834: Create named Redis key prefixes for EDA

Sample keys after the patch:

bzwei commented 3 months ago

@jamesmarshall24 @msmagnanijr If this PR is approved we need to make sure the scheduler in VM and OCP deployments now has a dependency on eda-api on start-up.

bzwei commented 3 months ago

LGTM, seems working as expected I can not see any other rq key. Automated and manual tests pass.

I strongly recommend to fully freeze the version constraint for rq stuff (rq, django-rq rq-scheduler) and take care explicitly of any library upgrade while this monkeypatch is active.

rq is now pinned to 1.13.0. django-rq is pinned to 2.8.0. rq-scheduler had been pinned to 0.10.