search

ansible / eda-server

Event Driven Ansible for AAP
Apache License 2.0
64 stars 41 forks source link

test: add e2e multinode for e2e-dispatch workflow #901

Closed Alex-Izquierdo closed 3 months ago

Alex-Izquierdo commented 3 months ago

Add to the e2e-dispatch workflow the tests for multinode based on docker-compose-dev implemented in https://github.com/ansible/eda-qa/pull/370 Jira: https://issues.redhat.com/browse/AAP-23959

Alex-Izquierdo commented 3 months ago

Unfortunately this can not be tested until merge it because on-demand workflows are always read from the main branch.

Dostonbek1 commented 3 months ago

Unfortunately this can not be tested until merge it because on-demand workflows are always read from the main branch.

Can it not be tested in fork?

Alex-Izquierdo commented 3 months ago

Unfortunately this can not be tested until merge it because on-demand workflows are always read from the main branch.

Can it not be tested in fork?

It would require to rewrite the main branch as well as the workflow, not mention the need to replicate the secrets. The amount of necessary differences makes a less reliable proof. I think in this case the effort it not worth, in eda-qa repo we do the same. In the unlikely case of some error, once the job is in main, we can detect easier the problem and fix it here, which I think it would be easier.