alikins
commented
4 years ago Trying to reproduce this with httpie sending a plain text file
(.venv) [newswoop:F31:pulpcore (master % u=)]$ HTTP_PROXY=localhost:8088 http -f POST http://localhost:5001/api/automation-hub/v3/artifacts/collections/ < README.md
HTTP/1.1 400 Bad Request
Allow: POST, OPTIONS
Content-Length: 136
Content-Type: application/json
Date: Wed, 12 Feb 2020 15:02:45 GMT
Server: WSGIServer/0.2 CPython/3.6.8
X-Frame-Options: SAMEORIGIN
{
"errors": [
{
"code": "required",
"detail": "No file was submitted.",
"source": {
"parameter": "file"
},
"status": "400",
"title": "Invalid input."
}
]
}
sending a tarfile:
(.venv) [newswoop:F31:pulpcore (master % u=)]$ HTTP_PROXY=localhost:8088 http --all --verbose -f POST http://localhost:5001/api/automation-hub/v3/artifacts/collections/ < stuff.tar.gz
POST /api/automation-hub/v3/artifacts/collections/ HTTP/1.1
Accept: */*
Accept-Encoding: gzip, deflate
Connection: keep-alive
Content-Length: 572
Content-Type: application/x-www-form-urlencoded; charset=utf-8
Host: localhost:5001
User-Agent: HTTPie/1.0.2
+-----------------------------------------+
| NOTE: binary data not shown in terminal |
+-----------------------------------------+
HTTP/1.1 400 Bad Request
Allow: POST, OPTIONS
Content-Length: 136
Content-Type: application/json
Date: Wed, 12 Feb 2020 15:06:31 GMT
Server: WSGIServer/0.2 CPython/3.6.8
X-Frame-Options: SAMEORIGIN
{
"errors": [
{
"code": "required",
"detail": "No file was submitted.",
"source": {
"parameter": "file"
},
"status": "400",
"title": "Invalid input."
}
]
}
ironfroggy
chouseknecht
Bug Report
SUMMARY
HTTP multipart form-data file uploads define the filename as strictly optional but our API requires the filename be included with the uploaded file data. However, if an HTTP compliance file upload is submitted omitting the filename as part of the data, the resulting error is incorrect and does not make the correction clear.
STEPS TO REPRODUCE
Construct form-data compliant payload with the a tarball attachment, omitting the
filenamemetadata, and upload it.EXPECTED RESULTS
An error about the filename indicating the problem, as it cannot be matched with its expected namespace OR The namespace, name, and version to be used from the metadata and the filename ignored.
ACTUAL RESULTS
A 400 HTTP response with the error message
"The submitted data was not a file."