search

ansible / galaxy-issues

This repository exists solely for the tracking of user issues with Ansible Galaxy.
20 stars 3 forks source link

Import fails when the file type of `README` is unknown #261

Closed larskarlitski closed 6 years ago

larskarlitski commented 7 years ago

Importing a role with a README that isn't plain text, markdown, or restructured text fails with

Unable to determine README file type. Expecting file extension to be one of: .md, .rst

The whole point of these formats is that they're readable as plain text as well. Failing the import because of this seems disproportionate.

Possible solution: treat README files with unknown extensions as plain text.

chouseknecht commented 7 years ago

Checking for an extension of .md or .rst is left over from the days when Galaxy converted the file to HTML. Now it accepts whatever HTML is returned from GitHub API.

We could modify it to accept files with no extension as text. Not a high priority at the moment though.

chouseknecht commented 6 years ago

This issue was moved to ansible/galaxy#50