search

ansible / galaxy

Legacy Galaxy still available as read-only on https://old-galaxy.ansible.com - looking for the new galaxy -> https://github.com/ansible/galaxy_ng
Apache License 2.0
853 stars 328 forks source link

Deleted GitHub Repositories stay in Ansible Galaxy with no indication. #2183

Open jonpugh opened 4 years ago

jonpugh commented 4 years ago

Bug Report

I was digging through a git repo for work and found the role dstil/upstart: https://galaxy.ansible.com/dstil/upstart

Looks nice, so I add it to my YML file. On ansible-galaxy install:

- downloading role 'upstart', owned by dstil
- downloading role from https://github.com/dstil/ansible-upstart/archive/master.tar.gz
 [ERROR]: failed to download the file: HTTP Error 404: Not Found

Huh? I confirm the role name, same thing. I go to https://galaxy.ansible.com/dstil/upstart, looks good. 4 years old, but good.

I click the GitHub Repo Link: https://github.com/dstil/ansible-upstart

404!

EXPECTED RESULTS

Not really sure what should happen here, but it seems to me that your API should treat the role as Not Found if there is no git repo?

There's the "deprecated" flag.

I am not sure how other systems deal with this. Maybe that's a good place to look? What does packagist.org or npm do when a git repo disappears?

Thanks!

chouseknecht commented 4 years ago

At one time there was a process for removing roles where the GitHub repo was no longer accessible. Not sure of the state of it these days.

jonpugh commented 4 years ago

Maybe it's best to keep the page on ansible-galaxy unless an owner explicitly deletes it so there's a history and it's findable, but the API and the website should know about it being disabled or something because there is nowhere to download the code.