search

ansible / galaxy_collection

Collection of modules and roles to configure Automation Hub
GNU General Public License v3.0
54 stars 50 forks source link

Timeout parameter in repository_sync does not work; Was it meant to be an async parameter? #398

Closed dbk-rabel closed 1 month ago

dbk-rabel commented 1 month ago

Hi.

https://github.com/ansible/galaxy_collection/blob/devel/roles/repository_sync/README.md?plain=1#L60 says, that the timeout parameter for repository_sync does the following: "If waiting for the project to update this will abort after this amount of seconds."

It doesn't. Actually it doesn't seem to have a lot of effect.

What would be useful instead (and maybe was intended here), would be to be able to increase the async parameter: https://github.com/ansible/galaxy_collection/blob/devel/roles/repository_sync/tasks/main.yml#L32C10-L32C14

Maybe it would also make sense to have a globale parameter called ah_configuration_async_timeout or something to set this.

But especially for repository_sync it is necessary, because you can easily get above 1000 seconds.

Yours David

dbk-rabel commented 1 month ago

Ok, probably the timeout parameter is not exactly what I was looking for.

Would be good to add some ah_configuration_async_timeout parameter. I will prepare a pull request and you can tell me if this is a good idea.