ansible / mazer

Experimental Ansible Galaxy Content Manager
GNU General Public License v3.0
114 stars 18 forks source link

Stop ignoring artifact download failures (404's etc) #280

Closed alikins closed 5 years ago

alikins commented 5 years ago
SUMMARY

Stop ignoring artifact download failures (404's etc)

Restructure download.fetch_url() a bit, and use raise_for_status() to trigger exceptions on any errors. Since this was ported to requests, errors for downloads have been ignored (at least until we attempt to read/install the results of the download request and they are not valid collection artifacts)

Fixes #272

ISSUE TYPE
MAZER VERSION
name = mazer
version = 1.0.0
config_file = /home/adrian/.ansible/mazer.yml
uname = Linux, newswoop, 5.0.5-200.fc29.x86_64, #1 SMP Wed Mar 27 20:58:04 UTC 2019, x86_64
executable_location = /home/adrian/venvs/mazer_0.4.0_py36/bin/mazer
python_version = 3.6.8 (default, Jan 27 2019, 09:00:23) [GCC 8.2.1 20181215 (Red Hat 8.2.1-6)]
python_executable = /home/adrian/venvs/mazer_0.4.0_py36/bin/python
ADDITIONAL INFORMATION