Validators could use more tests

ansible / molecule

Molecule aids in the development and testing of Ansible content: collections, playbooks and roles

https://ansible.readthedocs.io/projects/molecule/

MIT License

3.88k stars 662 forks source link

Validators could use more tests #353

Closed retr0h closed 8 years ago

retr0h commented 8 years ago

Validators have low coverage. Lets fix that.

molecule/validators.py                             69     49    29%

kireledan commented 8 years ago

Look's like the coverage isn't too too bad. Just the trailing that really needs most of the attention.

molecule/verifier/base.py                         7      1    86%
molecule/verifier/serverspec.py                  33      8    76%
molecule/verifier/testinfra.py                   33     11    67%
molecule/verifier/trailing.py                    54     33    39%

retr0h commented 8 years ago

Yeah, now that they were broken out, they got some extra coverage. The tree crawling going to be tricky.

retr0h commented 8 years ago

Going to close, we have bigger fish to fry, and is no longer an issue after the verifier refactoring.