ansible / product-demos

GNU General Public License v3.0
194 stars 194 forks source link

rhc system role implemention #70

Open willtome opened 1 year ago

willtome commented 1 year ago

Migrate from the insights collection and community module to the rhc system role. Display name functionality is lost. Needs a workaround.

This PR is blocked until the next release of the insights collection because tags are not working due to incorrect (cc: @richm)

richm commented 1 year ago

Migrate from the insights collection and community module to the rhc system role. Display name functionality is lost. Needs a workaround.

What do we need to do in the rhc system role for that?

This PR is blocked until the next release of the insights collection because tags are not working due to incorrect (cc: @richm)

Not sure what you mean by "the insights collection". The latest upstream release of the rhc role has the fix for the insights tagging - https://github.com/linux-system-roles/rhc/releases/tag/1.1.3 - and this is also in Galaxy - https://galaxy.ansible.com/linux-system-roles/rhc - and in the latest system roles collection - https://galaxy.ansible.com/fedora/linux_system_roles

If you mean Automation Hub then we're working on it - no ETA yet.

willtome commented 1 year ago

@richm Thanks for the comment. You read my mind. The error blocking this PR is the insights tagging. Once that is pushed to Hub this PR will be ready for review.

This project previously used the redhat.insights collection for registering hosts. With that functionality now part of the rhc role I wanted to migrate to that as the best practice for managing host registration.

Does the rhc role also support registration to Satellite? If so, perhaps that should be part of this PR as well.

If you would like to test: 1) red.ht/aap-product-demos 2) Login to controller, go to projects, change the branch of the "Ansible official demo project" to rhc 3) run the SETUP job template and select linux from the drop down. 4) run the Linux / Register with insights job. (this requires an activation key in your RH account RHEL8_Dev)

Would appreciate any feedback you have on how to best implement and demonstrate the role as it was intended to be used.

richm commented 1 year ago

@ptoscano see https://github.com/ansible/product-demos/pull/70#issuecomment-1579178858 - not sure if the rhc role supports Satellite - I think it does.

ptoscano commented 1 year ago

Hi @willtome,

nice to see the progress :) (for more general context: Will and me talked few days about about this & the insights collection)

Display name functionality is lost. Needs a workaround.

Most likely it can be set manually in the configuration of insights-client -- will let you know how exactly. (Yes, I have this noted as part of my to-do list for the rhc role.)

Does the rhc role also support registration to Satellite?

It does: either you need to set the various rhc_server/rh_baseurl variables yourself, or use the approach that configures subscription-manager on installation. I see the playbook already installs katello-ca-consumer-latest.noarch.rpm and does no other explicit changes in the subscription-manager configuration w.r.t. Satellite; hence, I tend to think that, if the playbook worked with Satellite before this PR, it would work fine as well using the rhc role.

Also, note that the role enables additional Insights bits by default, i.e. currently the remediation. So if they are not needed for this demo, I suggest disabling them (or only those not need):

  rhc_insights:
    remediation: absent

Nice job, looks slick!

jce-redhat commented 11 months ago

@willtome any update on this before you head out?

ptoscano commented 8 months ago

Few months later, a good update on this.

Version 1.23.0 of the redhat.rhel_system_roles collection ships with an rhc that supports setting a display name in Red Hat Insights for systems -- simply add a display_name attribute inside rhc_insights::

  rhc_insights:
    display_name: "{{ inventory_hostname }}"

@willtome would you have time to update this work, and give it a try? Thanks!