ansible / receptor

Project Receptor is a flexible multi-service relayer with remote execution and orchestration capabilities linking controllers with executors across a mesh of nodes.
Other
164 stars 82 forks source link

excess Error: messages in the logs, under normal operating conditions #510

Open fosterseth opened 2 years ago

fosterseth commented 2 years ago

Ever since https://github.com/ansible/receptor/pull/459, the log output shows a handful of error messages, even under normal conditions.

e.g.

ERROR 2021/12/06 15:53:25 Read error in control service: read unix /var/run/awx-receptor/receptor.sock->@: use of closed network connection

and

tools_receptor_1 | ERROR 2021/12/06 20:34:23 Read error in control service: Application error 0x0: normal close
tools_receptor_1 | INFO 2021/12/06 20:34:23 Client disconnected from control service awx_1:3NLfWPva
tools_receptor_1 | ERROR 2021/12/06 20:34:23 Read error in control service: Application error 0x0: normal close
tools_receptor_1 | INFO 2021/12/06 20:34:23 Client disconnected from control service awx_1:ot1yWhdj
tools_receptor_2 | ERROR 2021/12/06 20:34:23 Read error in control service: Application error 0x0: normal close
tools_receptor_2 | INFO 2021/12/06 20:34:23 Client disconnected from control service awx_1:JIeKbWgy
tools_receptor_2 | ERROR 2021/12/06 20:34:23 Read error in control service: Application error 0x0: normal close
tools_receptor_2 | INFO 2021/12/06 20:34:23 Client disconnected from control service awx_1:pg553aDk

we should find a way to better address this so that Error is more meaningful when we examine the logs

ghjm commented 2 years ago

For sure that "normal close" shouldn't be there

shanemcd commented 2 years ago

@fosterseth Should we backport this for 1.1?