Code refactor + new features

ansible / terraform-provider-ansible

community terraform provider for ansible

https://registry.terraform.io/providers/ansible/ansible/latest

GNU General Public License v3.0

201 stars 45 forks source link

Code refactor + new features #109

Open abikouo opened 7 months ago

abikouo commented 7 months ago

Closes #69 Closes #71

This pull request includes the following changes:

Code refactoring to use acceptance tests framework
Add new features for resource/playbook: skip_tags and start_at_task

gravesm commented 7 months ago

Can you break this up into multiple PRs? At the very least, the refactoring should be in its own PR. It's really hard to tell why most of the changes in this PR were made. Ideally, a PR should be focused and fix one problem.

abikouo commented 7 months ago

Can you break this up into multiple PRs? At the very least, the refactoring should be in its own PR. It's really hard to tell why most of the changes in this PR were made. Ideally, a PR should be focused and fix one problem.

@gravesm thanks for the feedback. 2 PRs will be generated, here the first one https://github.com/ansible/terraform-provider-ansible/pull/111 The next one introducing new features will be created one this one is merged