search

ansible / terraform-provider-ansible

community terraform provider for ansible
https://registry.terraform.io/providers/ansible/ansible/latest
GNU General Public License v3.0
183 stars 42 forks source link

Release 1.2.0 #87

Closed mandar242 closed 4 months ago

mandar242 commented 4 months ago
  1. Updated the version number to 1.2.0
  2. Ran go generate to regenerate docs
  3. Ran antsibull-changelog release --version 1.2.0
gravesm commented 4 months ago

Could you reissue this against the stable-1 branch? We should do releases from that.

sikha-root commented 4 months ago

Hi! I'm not sure if this affects this PR or not, but:

go.mod currently pins this provider to 1.18, and when I personally attempted to create my own release (following the README) using the already defined GHA workflows it was failing to build on the above dependencies^1. I'm not familiar with golang development but I assume this means that this project needs to be updated to use go 1.20 or 1.21?

gravesm commented 4 months ago

@sikha-root Thanks for catching this. Yes, we need to update the version in go.mod.

sikha-root commented 4 months ago

@gravesm Should I create a new PR based off what I tried the day before yesterday? https://github.com/317project/terraform-provider-ansible/compare/release_1_2_0_prep...317project:terraform-provider-ansible:main (ignoring the goreleaser config changes)

gravesm commented 4 months ago

Sure, if you wouldn't mind creating a PR to update this, that would be great. I'd like to also update https://github.com/ansible/terraform-provider-ansible/blob/e5e644864010e43ca53bcb37cbc8b04e5e9bc871/.github/workflows/integration.yml#L30 to use go-version-file: 'go.mod'. This will ensure the same version is being used to run integration tests as the version being used to build releases. This way we can catch these problems sooner.

gravesm commented 4 months ago

This PR appears to still be based off of the main branch, which is why it's duplicating commits that have been backported to the stable-1 branch. The commit that you've made should be rebased on the stable-1 branch.