candidate: network.backup

[alisonlhart]

Candidate Name

network.backup

Link to Github Repo

https://github.com/ansible-network/network.backup

Review Due By

Aug 23

CHECKLIST

Business Checks:

Content Viability

• [x] must support a “business-viable” use case
• [x] isn’t just a demo
• [x] is production-ready, as in able to run in Ansible Controller “as-is”
• [x] provides a solution an end-to-end automation use case and brings value to our customers

Content Duplication

• [x] use case addressed by the content isn’t covered by another validated content collection already - to the best of our knowledge

Technical Checks:

Content Conformity

• [x] is packaged as a content collection - see the Collection Requirements Checklist
• [x] is YAML only (Exception: if plugin(s) included are necessary for this specific use-case and are not generic enough for a certified collection)
• [x] if there is a plugin(s), it is not a duplicate of something from a certified or supported collection - to the best of our knowledge
• [x] supported plugin/module used in a validated role is noted as a dependency

Content Compliance

• [x] no known policy or legal reason for why the content shouldn’t be published
• [x] README contains information about the purpose of the collection and how to install it
• [x] README contains a link to the collection license file
• [x] README contains general usage and requirements information such as required versions of ansible-core and Python, and other required libraries or SDKs
• [x] Repo is self-certified with the OpenSSF Best Practices and has the OpenSSF Best Practices Badge
• [x] Has 2 or more active maintainers listed in a CODEOWNERS file.
• [x] Has an approved OSI license
• [x] Content falls logically into one of these domains - infra, security, network, cloud, edge
• [x] (If internal content) Content has been or is being migrated into the redhat-cop Github org

Content Testing/Validation

• [x] runs ansible-lint “Production” profile in an active Github workflow on the repository
• [x] passes the ansible-lint “Production” profile
• [x] ansible-lint.yml file (if present) only contains justified ignores - with a comment explaining the need for each ignore

[alisonlhart]

Initial PE review:

• Needs Install section in the README
• Needs additional maintainer in the CODEOWNERS file (if possible)
• Missing the meta/runtime.yml file
• Not passing ansible-lint Production profile
• Needs to be migrated into redhat-cop (before final approval)

[alisonlhart]

@arnav3000

[Fale]

In addition to the points highlighted by @alisonlhart, it needs to be tagged (>=1.0.0) and published on galaxy

[alisonlhart]

The full network.base collection contents are inside the roles/ dir. This should be removed.

[alisonlhart]

@rohitthakur2590 The final items that need to be fixed before approval:

• The full network.base collection contents are inside the roles/ dir. This should be removed.
• Needs Install section in the README
• Needs additional maintainer in the CODEOWNERS file (if possible)
• Not passing ansible-lint Production profile
• Migrate content into the redhat-cop Github Org. Open a repository management issue here. Reach out to @Andrew Block in RH slack with any migration questions.
• Bump version from 0.0.1 to a prod release of 1.0.0+

[alisonlhart]

Final Items needed: Install Section in the README @rohitthakur2590

[alisonlhart]

Approved.