candidate: network.toolkit

[IPvSean]

Candidate Name

network.toolkit

Link to Github Repo

toolkit

Review Due By

no timeline for me yet

CHECKLIST

Business Checks:

Content Viability

• [X] must support a “business-viable” use case
• [X] isn’t just a demo
• [X] is production-ready, as in able to run in Ansible Controller “as-is”
• [X] provides a solution an end-to-end automation use case and brings value to our customers

Content Duplication

• [X] use case addressed by the content isn’t covered by another validated content collection already - to the best of our knowledge

Technical Checks:

Content Conformity

• [X] is packaged as a content collection - see the Collection Requirements Checklist
• [X] is YAML only (Exception: if plugin(s) included are necessary for this specific use-case and are not generic enough for a certified collection)
• [X] if there is a plugin(s), it is not a duplicate of something from a certified or supported collection - to the best of our knowledge
• [X] supported plugin/module used in a validated role is noted as a dependency

Content Compliance

• [X] no known policy or legal reason for why the content shouldn’t be published
• [X] README contains information about the purpose of the collection and how to install it
• [x] README contains a link to the collection license file
• [X] README contains general usage and requirements information such as required versions of ansible-core and Python, and other required libraries or SDKs
• [ ] Repo is self-certified with the OpenSSF Best Practices and has the OpenSSF Best Practices Badge
• [X] Has 2 or more active maintainers listed in a CODEOWNERS file.
• [X] Has an approved OSI license
• [X] Content falls logically into one of these domains - infra, security, network, cloud, edge
• [ ] (If internal content) Content has been or is being migrated into the redhat-cop Github org

Content Testing/Validation

• [ ] runs ansible-lint “Production” profile in an active Github workflow on the repository
• [ ] passes the ansible-lint “Production” profile
• [ ] ansible-lint.yml file (if present) only contains justified ignores - with a comment explaining the need for each ignore

[IPvSean]

(If internal content) Content has been or is being migrated into the redhat-cop Github org

Is this something we have to do? This would take quite a bit of unscoped work where I need to go into ansible/workshops and instruqt and point to the new repo and test... why can't the content just stay here?

[IPvSean]

FYI around ansible-lint, I have some concerns here: https://github.com/ansible/ansible/pull/80746

[IPvSean]

unclear what I am needed to do with the OpenSSF Best Practices. It seems to run some sorta lint tool, but doesn't tell me "what" to do to fix the ?

[IPvSean]

[alisonlhart]

Picking up this issue again! @IPvSean The ABU has taken a pretty firm stance on requiring internal content to migrate into redhat-cop, for governance reasons.

For OpenSSF standards, @ericzolf may be able to give guidance and recommendations.

[ericzolf]

IPvSean for a network collection, how sweet... There isn't a lint tool as far as I know, it's more or less just a self-assessment questionnaire, where a question mark is the default state until you give a proper answer to the question. If you click on Edit at the top, you can simply click yourself through the questionnaire. Feel free to chat me if you have a specific question.