candidate: cloud.terraform_ops

alinabuzachis commented 6 months ago

Candidate Name

cloud.terraform_ops

Link to Github Repo

https://github.com/redhat-cop/cloud.terraform_ops

Review Due By

CHECKLIST

Business Checks:

Content Viability

[x] must support a “business-viable” use case
[x] isn’t just a demo
[x] is production-ready, as in able to run in Ansible Controller “as-is”
[x] provides a solution an end-to-end automation use case and brings value to our customers

Content Duplication

[x] use case addressed by the content isn’t covered by another validated content collection already - to the best of our knowledge

Technical Checks:

Content Conformity

[x] is packaged as a content collection - see the Collection Requirements Checklist
[x] is YAML only (Exception: if plugin(s) included are necessary for this specific use-case and are not generic enough for a certified collection)
[x] if there is a plugin(s), it is not a duplicate of something from a certified or supported collection - to the best of our knowledge
[x] supported plugin/module used in a validated role is noted as a dependency

Content Compliance

[x] no known policy or legal reason for why the content shouldn’t be published
[x] README contains information about the purpose of the collection and how to install it
[x] README contains a link to the collection license file
[x] README contains general usage and requirements information such as required versions of ansible-core and Python, and other required libraries or SDKs
[ ] Repo is self-certified with the OpenSSF Best Practices and has the OpenSSF Best Practices Badge
[x] Has 2 or more active maintainers listed in a CODEOWNERS file.
[x] Has an approved OSI license
[x] Content falls logically into one of these domains - infra, security, network, cloud, edge
[x] (If internal content) Content has been or is being migrated into the redhat-cop Github org

Content Testing/Validation

[x] runs ansible-lint “Production” profile in an active Github workflow on the repository
[x] passes the ansible-lint “Production” profile
[x] ansible-lint.yml file (if present) only contains justified ignores - with a comment explaining the need for each ignore

alisonlhart commented 5 months ago

Adding this to the agenda for the upcoming ACoP call on March 6, with final sign-off on March 20 to allow for sufficient review.

djdanielsson commented 5 months ago

why is there no meta.yml file in each of the roles? also you call out dependencies: amazon.aws and community.aws. but that would only be if they are using aws correct? but you do not call out azure or gcp. I wonder if you should remove those dependencies listed in the galaxy.yml file completely and leave the documentation as what a dependency depending on what role you are using

alinabuzachis commented 5 months ago

why is there no meta.yml file in each of the roles? also you call out dependencies: amazon.aws and community.aws. but that would only be if they are using aws correct? but you do not call out azure or gcp. I wonder if you should remove those dependencies listed in the galaxy.yml file completely and leave the documentation as what a dependency depending on what role you are using

@djdanielsson I opened a PR specify requirements at the role level and removed dependencies from galaxy.yml https://github.com/redhat-cop/cloud.terraform_ops/pull/10. Let me know please if this is what you mean.

alisonlhart commented 5 months ago

@arnav3000 @ericzolf @sean-m-sullivan Can you take a look at this candidate?

djdanielsson commented 5 months ago

I do not see any other issues currently. If anyone else has a minute to review and see if I missed anything.

alisonlhart commented 4 months ago

This appears to be ready for approval. Posting a final message in the cop-automation channel to do the sign-off asynchronously.

alisonlhart commented 4 months ago

Approved by the ACop! @alinabuzachis Feel free to release to Automation Hub at your discretion.

ansible / validated-content-discussion