candidate: infra.convert2rhel

r0x0d commented 5 months ago

Candidate Name

infra.convert2rhel

Link to Github Repo

https://github.com/redhat-cop/infra.convert2rhel

Review Due By

03/25/2024

CHECKLIST

Business Checks:

Content Viability

[x] must support a “business-viable” use case
[x] isn’t just a demo
[x] is production-ready, as in able to run in Ansible Controller “as-is”
[x] provides a solution an end-to-end automation use case and brings value to our customers

Content Duplication

[x] use case addressed by the content isn’t covered by another validated content collection already - to the best of our knowledge

Technical Checks:

Content Conformity

[x] is packaged as a content collection - see the Collection Requirements Checklist
[x] is YAML only (Exception: if plugin(s) included are necessary for this specific use-case and are not generic enough for a certified collection)
[x] if there is a plugin(s), it is not a duplicate of something from a certified or supported collection - to the best of our knowledge
[x] supported plugin/module used in a validated role is noted as a dependency

Content Compliance

[x] no known policy or legal reason for why the content shouldn’t be published
[x] README contains information about the purpose of the collection and how to install it
[x] README contains a link to the collection license file
[x] README contains general usage and requirements information such as required versions of ansible-core and Python, and other required libraries or SDKs
[x] install / requirements.yml information all points to Automation Hub, not a Github repo
[x] Repo is self-certified with the OpenSSF Best Practices and has the OpenSSF Best Practices Badge
[x] Has 2 or more active maintainers listed in a CODEOWNERS file.
[x] Has an approved OSI license
[x] Content falls logically into one of these domains - infra, security, network, cloud, edge
[x] (If internal content) Content has been or is being migrated into the redhat-cop Github org

Content Testing/Validation

[x] runs ansible-lint “Production” profile in an active Github workflow on the repository
[x] passes the ansible-lint “Production” profile
[x] ansible-lint.yml file (if present) only contains justified ignores - with a comment explaining the need for each ignore

alisonlhart commented 5 months ago

@djdanielsson @arnav3000 @ericzolf @sean-m-sullivan Can you take a look at this candidate?

djdanielsson commented 5 months ago

checklist isn't done, but skimming some of the code I think it is good.

r0x0d commented 4 months ago

Hi, it's been some time now... Should I check the boxes myself, or is this job for someone else to do?

djdanielsson commented 4 months ago

it is your job to check the boxes

r0x0d commented 4 months ago

Hi, @heatmiser, could you take a look for the Content Viability section, please? Thanks.

heatmiser commented 4 months ago

@r0x0d All items in Content Viability section are covered.

r0x0d commented 4 months ago

@alisonlhart, all items in check list are done.

alisonlhart commented 4 months ago

@r0x0d A few items I saw during review:

The galaxy.yml file includes a dep on fedora.linux_system_roles. This should be changed to the certified redhat.rhel_system_roles collection (downstream version of the same collection)
No CODEOWNERS file included
Is there a workflow running ansible-lint? This workflow says it in the name, but I don't see where the linter is actually running in the workflow.

r0x0d commented 4 months ago

Hi, @alisonlhart! Thanks for the comments.

Regarding the galaxy.yml and the CODEOWNERS file, here's the PR that fixes both of them: https://github.com/redhat-cop/infra.convert2rhel/pull/41

Regarding the workflow, you can see in the last line (https://github.com/redhat-cop/infra.convert2rhel/blob/main/.github/workflows/pre-commit.yml#L37) we call pre-commit action to execute pre-commit for us.

Our ansible-lint is being executed via pre-commit hook, that you can take a look at: https://github.com/redhat-cop/infra.convert2rhel/blob/main/.pre-commit-config.yaml#L14

alisonlhart commented 4 months ago

@r0x0d Thank you for pointing me to the correct file! I figured I was just missing it somewhere. After the PR is merged, I believe that meets all checklist criteria. I'll add this to the sign-off list for this week's ACoP call on April 17.

alisonlhart commented 4 months ago

Approved by the ACoP! @r0x0d please reach out to me on slack @allhart to get your access to the infra namespace on Automation Hub set up.

r0x0d commented 4 months ago

Approved by the ACoP! @r0x0d please reach out to me on slack @allhart to get your access to the infra namespace on Automation Hub set up.

Thanks, @alisonlhart!

We just merged https://github.com/redhat-cop/infra.convert2rhel/pull/41 and will be generating a new release soon!

ansible / validated-content-discussion