ansible / validated-content-discussion

A place for review of validated content candidates and general discussion around validated content.
GNU General Public License v3.0
2 stars 4 forks source link

candidate: cloud.vmware_ops #30

Closed machacekondra closed 4 months ago

machacekondra commented 4 months ago

Candidate Name

cloud.vmware_ops

Link to Github Repo

https://github.com/redhat-cop/cloud.vmware_ops

Review Due By

CHECKLIST

Business Checks:

Content Viability

Content Duplication

Technical Checks:

Content Conformity

Content Compliance

Content Testing/Validation

djdanielsson commented 4 months ago

I am wondering if we are going the wrong direction here, what if we created a collection that was about creating a VM and it would (in theory) support all the different hypervisors out there that way someone could easily use the same (or very close to) configuration to deploy a VM on any hypervisor they wanted? If we do not go that route I do think that should be the goal is to unify any other collections that create VMs to match as closely as possible.

machacekondra commented 4 months ago

Well, we intend to support more use cases in this collection not only VM management. We would like to for example also support:

djdanielsson commented 4 months ago

so I guess the question is then, should we move out the VM management side and make that a collection that is not platform specific or do we just need to ensure that any future collections that create VMs follow as similar as possible format to make it as easy as possible to use the same data across different hypervisors to create VMs

machacekondra commented 4 months ago

so I guess the question is then, should we move out the VM management side and make that a collection that is not platform specific or do we just need to ensure that any future collections that create VMs follow as similar as possible format to make it as easy as possible to use the same data across different hypervisors to create VMs

I see there is for exampe in azure_ops the role to manage VM Why do you think there should be platform agnostic collection to create/manage VMs? I see it wasn't considered even with other platforms.

bardielle commented 4 months ago

@djdanielsson thank you for taking a look on our validated content collection.

I think that "abstract role" as you @djdanielsson suggested will be really complicated since each infrastructure has different variables and use cases coverage. Also, the dependencies will be much bigger than you really need for one infrastructure.

djdanielsson commented 4 months ago

I think we have come up with a plan for all this, and we just need a couple people to review the code base here.

alisonlhart commented 4 months ago

@arnav3000 @ericzolf @sean-m-sullivan Any thoughts on this candidate? We're going to vote for approval tomorrow in the ACoP call.

sean-m-sullivan commented 4 months ago

I've reviewed and it looks good, voting for approval, I will not be able to make it to the meeting.

alisonlhart commented 4 months ago

Approved by the ACop! Feel free to release to Automation Hub at your discretion.

bardielle commented 4 months ago

Thanks a lot @alisonlhart, @sean-m-sullivan and the team