Playbook Explanation Thumbs button visibility issue

ansible / vscode-ansible

vscode/vscodium extension for providing Ansible auto-completion and integrating quality assurance tools like ansible-lint, ansible syntax check, yamllint, molecule and ansible-test.

https://ansible.readthedocs.io/projects/vscode-ansible/

MIT License

360 stars 86 forks source link

Playbook Explanation Thumbs button visibility issue #1347

Closed TamiTakamiya closed 3 months ago

TamiTakamiya commented 3 months ago

Improve the visibility of Thumbs Up/Down buttons on the playbook explanation panel when the explanation text overwraps the button.

Without this PR:

With this PR:

TamiTakamiya commented 3 months ago

I'd preferred to have seen them move down so as not to overlap the text at all (I don't know if padding-top or margin-top would help or whether the icons end up getting clipped).

Yes, that's my preference as well. However, I wanted to make the changes minimum for this release.

But, as it stands, this does improve their visibility so approving 👍

Thanks!