search

ansible / vscode-ansible

vscode/vscodium extension for providing Ansible auto-completion and integrating quality assurance tools like ansible-lint, ansible syntax check, yamllint, molecule and ansible-test.
https://ansible.readthedocs.io/projects/vscode-ansible/
MIT License
337 stars 77 forks source link

Fix creator folder opening #1376

Closed priyamsahoo closed 2 weeks ago

priyamsahoo commented 2 weeks ago

Adds the ability to open the workspace folder after scaffolding is done based on the workspace folder count. This resolves the issue of ansible-creator scaffolding not working when used multiple times. Fixes: #1217.

omaciel commented 2 weeks ago

Will there be tests added/updated as part of this PR?

ganeshrn commented 2 weeks ago

Will there be tests added/updated as part of this PR?

That's a good catch, the coverage is reduced by 0.2%. @priyamsahoo Can you please add test cases to this PR.

priyamsahoo commented 2 weeks ago

@omaciel, @ganeshrn, as of now, there are no tests for the ansible-creator scaffolding features. I am in the process of adding the tests (One of the PRs in this process is https://github.com/ansible/vscode-ansible/pull/1318). I should add the tests of all these together in the subsequent PRs.

omaciel commented 2 weeks ago

@priyamsahoo I don't want to introduce changes to your existing processes... yet ;) but I think it would give your PR a major boost of confidence if the tests were part of it

priyamsahoo commented 2 weeks ago

In that case, this PR has to wait for a week or two before I set up the testing framework for Ansible content creator web views in the extension (which is currently nonexistent).

omaciel commented 2 weeks ago

@priyamsahoo sounds like a great opportunity to handle an existing technical debt then?