Closed romartin closed 1 week ago
Thanks @TamiTakamiya !! Well this solution is not perfect, but at least we are increasing the use cases covered, without spending lot of time here. All existing tests are passing, so sounds good, also I am working on increasing the coverage now , once done I will update the PR.
BTW You had a chance to test it?
Thanks!
Increased test coverage!! also rebased :+1:
See https://issues.redhat.com/browse/AAP-24192
Description
The goal is to provide some quick fix some more common use cases, where action feedback is being handled in a wrong way, without a need for a bigger refactoring.
This PR improves the lifecycle of completion / feedback events , by assuming that several completion requests can be sent, before the suggestion is displayed to the user, this way:
HTTP 200
) completion request, it will end up on an action feedback event, can be accepted, rejected or ignoredTested use cases
accept
,acceptKey
) also by using keys (Tab
,Esc
)TODO: Update/add unit tests