ansible / vscode-ansible

vscode/vscodium extension for providing Ansible auto-completion and integrating quality assurance tools like ansible-lint, ansible syntax check, yamllint, molecule and ansible-test.
https://ansible.readthedocs.io/projects/vscode-ansible/
MIT License
337 stars 77 forks source link

Action field in Recommendation events have a blank/null value #1381

Closed romartin closed 1 week ago

romartin commented 2 weeks ago

See https://issues.redhat.com/browse/AAP-24192

Description

The goal is to provide some quick fix some more common use cases, where action feedback is being handled in a wrong way, without a need for a bigger refactoring.

This PR improves the lifecycle of completion / feedback events , by assuming that several completion requests can be sent, before the suggestion is displayed to the user, this way:

Tested use cases

TODO: Update/add unit tests

romartin commented 2 weeks ago

Thanks @TamiTakamiya !! Well this solution is not perfect, but at least we are increasing the use cases covered, without spending lot of time here. All existing tests are passing, so sounds good, also I am working on increasing the coverage now , once done I will update the PR.

BTW You had a chance to test it?

Thanks!

romartin commented 2 weeks ago

Increased test coverage!! also rebased :+1: