ansible / vscode-ansible

vscode/vscodium extension for providing Ansible auto-completion and integrating quality assurance tools like ansible-lint, ansible syntax check, yamllint, molecule and ansible-test.
https://ansible.readthedocs.io/projects/vscode-ansible/
MIT License
363 stars 92 forks source link

Updating vscode-extension-tester to 8.4.0 and the vscode version used during testing breaks tests #1464

Open ssbarnea opened 3 months ago

ssbarnea commented 3 months ago

Seen on https://github.com/ansible/vscode-ansible/actions/runs/10160587251/job/28097290030?pr=1462#step:12:422 which updated

NoSuchElementError: no such element: Unable to locate element: {"method":"css selector","selector":".monaco-workbench"}

This is very unlikely to be caused by a regression with https://github.com/redhat-developer/vscode-extension-tester/releases/tag/v8.4.0 but more likely to be effect of switching vscode max version used for testing https://github.com/redhat-developer/vscode-extension-tester/pull/1400

This should be treated as very important, as it might indicate even runtime problems with current version of vscode.

alisonlhart commented 2 months ago

Possibly fixed in https://github.com/redhat-developer/vscode-extension-tester/pull/1485, will verify.

alisonlhart commented 2 months ago

The extester 8.6.0 release results in the same failure. https://github.com/alisonlhart/vscode-ansible/actions/runs/10585584457/job/29332508066?pr=3#step:14:323 Adding an update on the issue.