ansible / workshops

Training Course for Ansible Automation Platform
MIT License
1.75k stars 1.14k forks source link

provisioner aws_dns role is tied to create_login_page #394

Closed IPvSean closed 4 years ago

IPvSean commented 5 years ago
SUMMARY

this code for aws_dns https://github.com/ansible/workshops/blob/master/provisioner/provision_lab.yml#L107-L116 makes dependency on another role aws_workshop_login_page. we should not have a dependency on the other role

ISSUE TYPE
EXTRA VARS FILE
create_login_page: false
# when towerinstall is on, this will license it with provided license
autolicense: true
# this will install Ansible Tower on all control nodes
towerinstall: true

e.g. here is an example of an extra vars file we are looking for:

$ cat ~/Github/linklight/provisioner/seans_workshop.yml
---
ec2_region: us-east-1
ec2_name_prefix: seantest
student_total: 25
admin_password: ansible
create_login_page: true
ANSIBLE VERSION
2.8.x
CONFIGURATION

n/a

OS / ENVIRONMENT

n/a

TOWER

n/a

PLAYBOOK SHORT OUTPUT
n/a
PLAYBOOK LONG OUTPUT
n/a
IPvSean commented 4 years ago

this will start helping this ticket https://github.com/IPvSean/workshops/commit/cdb465f46f9cf3c05de64052ee6bccb5b5b32b8a