APB Run Command - Githubissues

djzager commented 6 years ago

This PR implements an apb run command that works even as a developer to run an APB in a specified namespace. There are some limitations:

Since apb build, prepare, etc. all work on the current apb project...this does that too. So I have to be "in" the 'hello-world-apb' project in order to apb-run that APB.
APBs that try to create anything above the permissions of a $namespace:admin will fail...hard.
APBs that use asb_encode_binding will fail because we aren't passing the POD_NAME and POD_NAMESPACE to the pod we create...I can add this. But I think the right thing from an APB developer perspective is to specifically create a secret when not using the ansible broker. However, I'm not sure how we would communicate that to APBs.

djzager commented 6 years ago

I still need to fix apb-test, cleanup the service accounts and role-bindings et al...but I wanted to get some eyeballs on this before I went through that trouble.

djzager commented 6 years ago

At this point, there are still some issues with apb test that I'm working through...but apb run should be done.

djzager commented 6 years ago

At this point apb test runs...but fails for some reason on the only apb for which we have a test playbook. This is worth investigation, but outside of the scope of this PR.

https://github.com/ansibleplaybookbundle/mediawiki-apb/issues/18 Created

dymurray commented 6 years ago

apb run worked for me first try! I'm really happy with this. Let's give folks a little more time to look at it but ACK from me.

djzager commented 6 years ago

(3) Experiment with 'apb run' command for running APBs outside of Broker

ansibleplaybookbundle / ansible-playbook-bundle

APB Run Command #178