Use the routing prefix for apb commands

ansibleplaybookbundle / ansible-playbook-bundle

THIS REPO IS MIGRATING: https://github.com/automationbroker/apb

GNU General Public License v2.0

140 stars 70 forks source link

Use the routing prefix for apb commands #186

Closed rthallisey closed 6 years ago

rthallisey commented 6 years ago

depends-on: https://github.com/openshift/ansible-service-broker/pull/616 fixes: https://github.com/ansibleplaybookbundle/ansible-playbook-bundle/issues/180

rthallisey commented 6 years ago

[3] APB Tooling improvements

dymurray commented 6 years ago

@rthallisey I'm good with these changes except for one thing. I had a similar change in my PR here: https://github.com/ansibleplaybookbundle/ansible-playbook-bundle/pull/187/files#diff-0fd87d319c78489a9552dbeb84adeae0R727 for the ansible-service-broker suffix. I tried a similar approach and found that this doesn't always work because a user could pass the suffix in and this would end up with /ansible-service-broker/ansible-service-broker. Let me know what you think about adding a check and appending when necessary.

rthallisey commented 6 years ago

I added print("Contacting the ansible-service-broker at: %s%s" % (broker, service_route)) to help alert the user to the final url being used. But, it's a temporary solution and I'm going to improve on this in other patches.

Future Additions:

Accept a route (without 'http/https'). This is what we ask for anyway.
Return an error on an invalid route and determine if the route is missing or mispelled. This will cover the case of ansible-service-broker/ansible-service-broker.
Always use https.