Generic tool improvements

ansibleplaybookbundle / ansible-playbook-bundle

THIS REPO IS MIGRATING: https://github.com/automationbroker/apb

GNU General Public License v2.0

140 stars 70 forks source link

Generic tool improvements #187

Closed dymurray closed 6 years ago

dymurray commented 6 years ago

Added apb setup
- Creates user apb-developer with cluster-admin rights
Added sanity checks for --broker suffix so that <route>/ansible-service-broker isn't required and just <route> will work.
make apb push -o the default apb push and old apb push functionality is apb push --push-to-broker.

dymurray commented 6 years ago

https://bugzilla.redhat.com/show_bug.cgi?id=1523252

rthallisey commented 6 years ago

Deprecate apb push and make apb push -o the default

We are not doing this any more right?

dymurray commented 6 years ago

@rthallisey you're right. I updated to reflect the changes.

rthallisey commented 6 years ago

We'll definitely need to get this in before I can merge my PR that adds classes

dymurray commented 6 years ago

@rthallisey thanks I had intended on printing the current logged in user but ran into issues didn't want to fight that. I plan on adding more to apb setup as we find the need for it.

rthallisey commented 6 years ago

@dymurray I'm good with merging this.

Also, if you can hold off on any apb changes for a day or two so I can get the PR done that adds classes, I'd really appreciate it. It's a massive patch and every rebase is going to be a pain. I'll post a WIP after I rebase on this patch.

rthallisey commented 6 years ago

fixes: https://github.com/openshift/ansible-service-broker/issues/623