search

ansibleplaybookbundle / ansible-playbook-bundle

THIS REPO IS MIGRATING: https://github.com/automationbroker/apb
GNU General Public License v2.0
140 stars 70 forks source link

Add example using oc new-app instead of apb push #257

Closed dymurray closed 6 years ago

jwmatthews commented 6 years ago

@akostadinov please take a look at the documentation workaround @dymurray proposes. Do you see any other issues or concerns we should address for a local developer who does not have docker access?

Our thought is to get a first pass of this working, then come back to fine tune the experience.
One of things for us to look into further is s2i integration, we've done some work already with a demo of functionality, be good for us to revisit and improve: https://www.youtube.com/watch?v=ZhLvlpqHI8U

akostadinov commented 6 years ago

@dymurray , hi, do I understand correctly that one needs to:

Just want to make sure I understand correctly. Other than that, I think this looks good. Would be ideal if at some point apb tool can work in the one more or the other depending on user choice.

@jianzhangbjz, FYI, maybe we can use more the OpenShift workflow in testing and low number of apb functionality tests.

jianzhangbjz commented 6 years ago

@akostadinov Yes, you're right. Thank you for your information.

dymurray commented 6 years ago

@akostadinov You do not need to run as cluster-admin in this regard to get oc new-app working. You will only need elevated permissions to get the broker commands to work (curl to bootstrap the broker for example).

Can you clarify what you meant by:

Just want to make sure I understand correctly. Other than that, I think this looks good. Would be ideal if at some point apb tool can work in the one more or the other depending on user choice.

Are you referring to different permissioning levels?

akostadinov commented 6 years ago

@dymurray , do you know which permissions would be enough? Perhaps we need do document them.

wrt work in the one mode or the other depending on user choice (I had a typo and initially wrote more instead of mode). I mean that apb could use the new-app approach instead of user calling oc new-app ... in case user request that.

dymurray commented 6 years ago

@akostadinov Yes I linked the permission documentation in this PR actually. And I see about your second point. Yes I think its worth filing an issue that we can trivially support this functionality with a new command in the tooling,

dymurray commented 6 years ago

@mhrivnak is this good to merge now?