Closed rthallisey closed 6 years ago
A few nitpicks. I don't have any experience with building APBs based off of existing Ansible projects. My impression is that the reuse should be at the role level, including specific roles into provision, deprovision, etc. but this may be a way to go about it.
For best practices I agree, but it depends how someone has written their playbook so this covers all the bases.
Another option I don't see mentioned is to simply copy the kubevirt.yml playbook into the APB container to actions/provision.yml. Not sure if that improves anything but I guess there are a good handful of options available to APB writers.
That's a possible option. It depends how the playbook is written, but in this case it would work.
@djzager @mhrivnak any more comments here? @jwmatthews is this doc in the right place to get added to origin docs?
further comments?
I view @fabianvf as a resource when talking about structuring and writing good Ansible. I think that he should have a look at this too.