ansibleplaybookbundle / ansible-playbook-bundle

THIS REPO IS MIGRATING: https://github.com/automationbroker/apb
GNU General Public License v2.0
140 stars 70 forks source link

Remove organization from the image field in the apb.yml #69

Closed cfchase closed 7 years ago

cfchase commented 7 years ago

Current behavior:

apb.yml

image: ansibleplaybookbundle/my-apb This means that the broker downloads the spec from an organization, but may actually download the image from an entirely different organization, leading to confusion.

Proposed:

apb.yml

image: my-apb ASB will assume the apb image is in the same repository and org where the spec was found.

Will require changes in:

Reasoning:

  1. Stable - Allow a user to download an image, retag it, and then push it to a different org for either testing or production use without modifying and rebuilding. We want to test the built image as is without modifying it and introducing changes.
  2. Less confusion - since a user may forget to change the org, they'd be testing the original image on a different org and may be confused why changes aren't reflected.
  3. Reusable - we would want users and developers to be sharing images without forcing them to rebuild the image with changes before pushing to their own organization for use.
cfchase commented 7 years ago

https://github.com/openshift/ansible-service-broker/issues/288 https://github.com/fusor/apb-examples/issues/81