ansibleplaybookbundle / kubevirt-apb

APB for managing KubeVirt deployments
Apache License 2.0
8 stars 16 forks source link

[WIP] Nested virt bool #19

Closed rthallisey closed 2 years ago

rthallisey commented 6 years ago

depends-on: https://github.com/openshift/ansible-service-broker/issues/812

fixes: #17

rthallisey commented 6 years ago

@mareklibra This may be out of scope of an apb because it involves making changes to a host machine. I created https://github.com/openshift/ansible-service-broker/issues/812 so there's a discussion around this started, but in the near term this probably makes more sense to do outside of an apb. If https://github.com/openshift/ansible-service-broker/issues/812 is merged later on, we can always come back and add this.

lukas-bednar commented 6 years ago

I was dealing with nested vt on our infra too, and here is how I deal with that, you could use there as well if you find it handy:

ovirt-infra commented 6 years ago

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project. As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically.
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.