search

ansibleplaybookbundle / postgresql-apb

An APB which deploys an RHSCL PostgreSQL instance
8 stars 12 forks source link

Parametrise service name #40

Open siamaksade opened 6 years ago

siamaksade commented 6 years ago

The service name for postgresql is hard-coded to postgresql: https://github.com/ansibleplaybookbundle/postgresql-apb/blob/master/roles/rhscl-postgresql-apb/tasks/main.yml#L28

It should be paramterized so that use can choose the service name during instantiation

djzager commented 6 years ago

This is related to https://bugzilla.redhat.com/show_bug.cgi?id=1542235.

djzager commented 6 years ago

This is a good issue @siamaksade and an excellent suggestion. When I was working on updating our hello-world-apb , I had originally made the names unique by using the _apb_service_instance_id. This gave the benefit of allowing multiple instances of the ServiceClass to be created in the same namespace without creating a new parameter...however I think that your suggestion is a better approach for solving this problem.

djzager commented 6 years ago

https://github.com/ansibleplaybookbundle/hello-world-apb/pull/3 has been merged and uses the _apb_service_instance_id a similar change will need to be made to postgresql-apb.

jwmatthews commented 6 years ago

We plan to address this issue with all database APBs in next sprint, should have this resolved ~middle of May.

Related trello card https://trello.com/c/5vybIGku