search

ansibleplaybookbundle / prometheus-apb

GNU General Public License v3.0
3 stars 4 forks source link

Install Grafana without proxy in the case that OAuth is disabled but Grafana is enabled #9

Closed cunningt closed 6 years ago

cunningt commented 6 years ago

If you choose to deselect the Oauth checkbox, but leave the Grafana checkbox checked, Grafana is not installed. Grafana should be installed in this case, without a proxy.

I had trouble getting the datasource creation working though - I'll add that in a later PR if I can get it working.

cunningt commented 6 years ago

@jparrill It looks like the tests here failed because --version is no longer a command line option 👍

$ oc cluster up --version=$OPENSHIFT_VERSION Error: unknown flag: --version

jparrill commented 6 years ago

I create a PR to your base repository fixing the tests for this PR. When you perform the merge, just ping me to warn the repository owner to be merged and published on the ASB Upstream.

jparrill commented 6 years ago

LGTM @dymurray could you please proceed to the merge and update the upstream image? :)

cunningt commented 6 years ago

@jparrill @dymurray Could we get this merged?

cunningt commented 6 years ago

@jparrill @dymurray This has been sitting out there for a while - any way we can get it merged?