ansilove / Ascension

ANSI/ASCII art viewer for Mac OS X
http://ascension.byteproject.net
BSD 3-Clause "New" or "Revised" License
169 stars 17 forks source link

2 recommendations + 2 possible issues #1

Closed nscoding closed 13 years ago

nscoding commented 13 years ago

Great work :)

Recommendations 1) I recommend you disable resize of the preferences window 2) You should add some icons for the .NFO and .DIZ files :)

Issues 1) Once I save a file I cannot perform undo! Is this intentional? 2) If I make a change and I revert everything turns black.

ByteProject commented 13 years ago

Thanks for the recommendations, of course the prefs window should not resize, I implement that as well as some neat icons into beta 2.

I confirm both issues.

Issue 1) This is not the way it should be, I'll check what I can do to make this better.

Issue 2) The text is there, but my custom NSParagraphstyle is gone, seems to be caused by NSDocumentController. I'll have a look how I can work around this, maybe I'll override it's revertToSaved method (if something like a [super revertToSaved] is existing. I'll check that out.

Both issues will be fixed in beta 2. I confirm them here as closed as soon as beta 2 is released. Thank you so much for your feedback ;)

ByteProject commented 13 years ago

Solved. Both issues are fixed in upcoming beta 2. I changed much of my text content handling in Ascension to achieve proper "undo after save" operations and no letters will be gone again when reverting to saved.

Beta2 should be available very soon. Still working on the icons.