search

ansistrano / deploy

Ansible role to deploy scripting applications like PHP, Python, Ruby, etc. in a capistrano style
https://ansistrano.com
MIT License
2.37k stars 343 forks source link

Rename sudo to become to avoid deprecation warnings #197

Closed FlxPeters closed 7 years ago

FlxPeters commented 7 years ago

This will fix the deprecation warnings. We test against Ansible 1.9, so this should not be a problem.

There is maybe just open question: We define Ansible 1.8 in the meta data, but we test against 1.9. What should be the minimum required version for Ansistrano? I think 1.9 is ok, because its the last of the 1.x branch and 2.x is there quiet a while.

What do you think?

ricardclau commented 7 years ago

We still support 1.8 but keeping compatibility is a bit painful, this is why we recently removed it from tests as for instance svn was broken, happy to bump to 1.9, thoughts @carlosbuenosvinos ?

ricardclau commented 7 years ago

Can you please also change min ansible version in the meta folder? We will move forward with this in a few days unless someone provides good reasons for not to :)

carlosbuenosvinos commented 7 years ago

LGTM