search

ansistrano / deploy

Ansible role to deploy scripting applications like PHP, Python, Ruby, etc. in a capistrano style
https://ansistrano.com
MIT License
2.37k stars 343 forks source link

Adding support for symlinked shared files and directories #231

Closed sad0vnikov closed 7 years ago

sad0vnikov commented 7 years ago

Hello! I think that shared files and directories can be symlinked. For example, I had to make them symlinked while setting up Ansistrano for a deployed production project. But if shared files are symlinked 'ANSISTRANO | Ensure shared paths exists' step would fail with "directory already exists as link error". So, I propose to add "follow: true" option to checking shared files and paths steps.

ricardclau commented 7 years ago

👎 here

I don't see the need for the first two follow: true and regarding shared elements, we recently added the option to skip these steps in https://github.com/ansistrano/deploy/pull/208 as @skuark was having a similar problem to yours

This is a bit of an edge case where you are introducing ansistrano in an already existing project so either #208 or some basic setup hook should do the trick. If you check the discussion in that PR you will see what I am referring to

sad0vnikov commented 7 years ago

You are probably right, Ricard. Skipping the check will do the trick. Since there're no any reasons to use symlinks for shared files besides adding Ansistrano to existing project, I'm closing the PR. Thank you for your reply.