search

ansistrano / deploy

Ansible role to deploy scripting applications like PHP, Python, Ruby, etc. in a capistrano style
https://ansistrano.com
MIT License
2.37k stars 343 forks source link

Hg support #235

Closed dgsuarez closed 7 years ago

dgsuarez commented 7 years ago

Hey,

I've been evaluating deployment options, ansistrano looks perfect but I'd need mercurial support. I started looking to see if it was simple to add and ended up with this.

It's missing stuff when compared with the git version, but before going any further I wanted to make sure that there's interest merging this, and get any comments you may have on the code so far.

ricardclau commented 7 years ago

Hi

There is definitely interest in merging this but none of us are mercurial users so it can be a bit tricky to provide valuable feedback

I see you have already added some tests which is great, let me have a look at it but everything looks pretty good

Thanks!

ricardclau commented 7 years ago

I checked the mercurial docs and this shell command seems to be the way to go

If you can add the fix I mentioned we will merge it straight away. Better to have not-perfect but working mercurial support than no support at all as we currently have

Thanks a lot for your work on this @dgsuarez

ricardclau commented 7 years ago

Thanks! Could you please add some docs in another PR as well?

dgsuarez commented 7 years ago

Sure! I should probably update defaults.yml as well right?

ricardclau commented 7 years ago

Yeah, at least ansistrano_hg_repo and ansistrano_hg_branch