search

ansistrano / deploy

Ansible role to deploy scripting applications like PHP, Python, Ruby, etc. in a capistrano style
https://ansistrano.com
MIT License
2.37k stars 343 forks source link

Fix regular expression mistake in Python 3.7 #324

Closed EugeneKey closed 5 years ago

EugeneKey commented 5 years ago

Python 3.7 subtly changed the behavior of re.sub() which leads to paths like ..../.... where they should look like ../...

By matching only non-empty path segments, there is no second-adjacent empty match that would be replaced.

ricardclau commented 5 years ago

This was fixed in https://github.com/ansistrano/deploy/pull/304

Not sure if you are running an outdated version

EugeneKey commented 5 years ago

This was fixed in #304

Not sure if you are running an outdated version

#304 was fixed issue on tasks/symlink-shared.yml

But I added similar fix for tasks/rsync-deploy.yml

The issue manifests itself when rcync is used for the current folder.

ricardclau commented 5 years ago

Oh sorry my bad! You are absolutely right and the github diff mislead me